Skip to content

Build/Analyze ignore package compatibility #43829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
Merged

Build/Analyze ignore package compatibility #43829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions eng/pipelines/templates/steps/analyze.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,14 @@ steps:
condition: and(succeededOrFailed(), ne(variables['Skip.VerifySdist'],'true'))
inputs:
scriptPath: 'scripts/devops_tasks/dispatch_tox.py'
arguments: '"$(TargetingString)" --service=${{parameters.ServiceDirectory}} --toxenv=verifysdist ${{ parameters.AdditionalTestArgs }}'
arguments: '"$(TargetingString)" --disable-compatibility-filter --service=${{parameters.ServiceDirectory}} --toxenv=verifysdist ${{ parameters.AdditionalTestArgs }}'

- task: PythonScript@0
displayName: 'Verify whl'
condition: and(succeededOrFailed(), ne(variables['Skip.VerifyWhl'],'true'))
inputs:
scriptPath: 'scripts/devops_tasks/dispatch_tox.py'
arguments: '"$(TargetingString)" --service=${{parameters.ServiceDirectory}} --toxenv=verifywhl ${{ parameters.AdditionalTestArgs }}'
arguments: '"$(TargetingString)" --disable-compatibility-filter --service=${{parameters.ServiceDirectory}} --toxenv=verifywhl ${{ parameters.AdditionalTestArgs }}'

- template: run_mypy.yml
parameters:
Expand All @@ -123,7 +123,7 @@ steps:
displayName: 'Run Keyword Validation Check'
inputs:
scriptPath: 'scripts/devops_tasks/dispatch_tox.py'
arguments: '"$(TargetingString)" --service=${{parameters.ServiceDirectory}} --toxenv=verify_keywords ${{ parameters.AdditionalTestArgs }}'
arguments: '"$(TargetingString)" --disable-compatibility-filter --service=${{parameters.ServiceDirectory}} --toxenv=verify_keywords ${{ parameters.AdditionalTestArgs }}'
condition: and(succeededOrFailed(), ne(variables['Skip.KeywordCheck'],'true'))

- template: ../steps/run_bandit.yml
Expand Down
1 change: 1 addition & 0 deletions eng/pipelines/templates/steps/run_bandit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ steps:
--mark_arg="${{ parameters.TestMarkArgument }}"
--service="${{ parameters.ServiceDirectory }}"
--toxenv="bandit"
--disable-compatibility-filter
--disablecov
${{ parameters.AdditionalTestArgs }}
env: ${{ parameters.EnvVars }}
Expand Down
1 change: 1 addition & 0 deletions eng/pipelines/templates/steps/run_black.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ steps:
"$(TargetingString)"
--service="${{ parameters.ServiceDirectory }}"
--checks="black"
--disable-compatibility-filter
--filter-type="Omit_management"
${{ parameters.AdditionalTestArgs }}
env:
Expand Down
1 change: 1 addition & 0 deletions eng/pipelines/templates/steps/run_breaking_changes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ steps:
--mark_arg="${{ parameters.TestMarkArgument }}"
--service="${{ parameters.ServiceDirectory }}"
--toxenv="breaking"
--disable-compatibility-filter
--disablecov
env: ${{ parameters.EnvVars }}
condition: and(succeededOrFailed(), ne(variables['Skip.BreakingChanges'],'true'))
1 change: 1 addition & 0 deletions eng/pipelines/templates/steps/run_mypy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ steps:
--service="${{ parameters.ServiceDirectory }}"
--checks="mypy"
--disablecov
--disable-compatibility-filter
${{ parameters.AdditionalTestArgs }}
env:
TOX_PIP_IMPL: "uv"
Expand Down
1 change: 1 addition & 0 deletions eng/pipelines/templates/steps/run_pylint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ steps:
"$(TargetingString)"
--service="${{ parameters.ServiceDirectory }}"
--checks="pylint"
--disable-compatibility-filter
--filter-type="Omit_management"
${{ parameters.AdditionalTestArgs }}
env:
Expand Down
2 changes: 2 additions & 0 deletions eng/pipelines/templates/steps/run_pyright.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ steps:
--mark_arg="${{ parameters.TestMarkArgument }}"
--service="${{ parameters.ServiceDirectory }}"
--toxenv="pyright"
--disable-compatibility-filter
--disablecov
${{ parameters.AdditionalTestArgs }}
condition: and(succeededOrFailed(), ne(variables['Skip.Pyright'],'true'))
Expand All @@ -30,6 +31,7 @@ steps:
--mark_arg="${{ parameters.TestMarkArgument }}"
--service="${{ parameters.ServiceDirectory }}"
--toxenv="verifytypes"
--disable-compatibility-filter
--disablecov
${{ parameters.AdditionalTestArgs }}
condition: and(succeededOrFailed(), ne(variables['Skip.Verifytypes'],'true'))
9 changes: 8 additions & 1 deletion eng/scripts/dispatch_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,13 @@ def handler(signum, frame):
help="Maximum number of concurrent checks (default: number of CPU cores).",
)

parser.add_argument(
"--disable-compatibility-filter",
dest="disable_compatibility_filter",
action="store_true",
help="Flag to disable compatibility filter while discovering packages.",
)

args = parser.parse_args()

configure_logging(args)
Expand All @@ -340,7 +347,7 @@ def handler(signum, frame):
args.filter_type = "Build"
compatibility_filter = False
else:
compatibility_filter = True
compatibility_filter = not args.disable_compatibility_filter

targeted_packages = discover_targeted_packages(
args.glob_string, target_dir, "", args.filter_type, compatibility_filter
Expand Down
2 changes: 1 addition & 1 deletion eng/tools/azure-sdk-tools/ci_tools/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def build() -> None:
target_dir,
args.package_filter_string,
filter_type="Build",
compatibility_filter=True,
compatibility_filter=False,
include_inactive=args.inactive,
)

Expand Down
9 changes: 8 additions & 1 deletion scripts/devops_tasks/dispatch_tox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,13 @@
help="Location to generate any output files(if any). For e.g. apiview stub file",
)

parser.add_argument(
"--disable-compatibility-filter",
dest="disable_compatibility_filter",
action="store_true",
help="Flag to disable compatibility filter while discovering packages.",
)

args = parser.parse_args()

configure_logging(args)
Expand All @@ -132,7 +139,7 @@
args.filter_type = "Build"
compatibility_filter = False
else:
compatibility_filter = True
compatibility_filter = not args.disable_compatibility_filter

targeted_packages = discover_targeted_packages(
args.glob_string, target_dir, "", args.filter_type, compatibility_filter
Expand Down
Loading