-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Conv inference py sdk 20251115preview #43832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conv inference py sdk 20251115preview #43832
Conversation
…nalyzeConversations/tspconfig.yaml', API Version: 2025-11-15-preview, SDK Release Type: beta, and CommitSHA: '5b0855a6739c8dbd68136d364d7fc5ed1aa0c43f' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5539661 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Azure AI Language Conversations SDK with several major changes:
- Updates API version from
2025-05-15-previewto2025-11-15-preview - Renames client class from
ConversationAnalysisClienttoConversationAnalysis - Adds LUIS (Language Understanding) support with new models (
LuisCallingConfig,LuisConfig,LuisResult,LuisTargetIntentResult) - Adds new PII categories for conversation analysis
- Updates type annotations from
List,Dicttolist,dict(modern Python typing) - Removes custom LRO poller implementation from patch files
- Updates package version from
2.0.0b1to1.0.0b1 - Adds generated test files and samples
Reviewed Changes
Copilot reviewed 57 out of 57 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tsp-location.yaml |
Updates spec directory path and commit hash |
sdk_packaging.toml |
Removes standalone packaging config file |
pyproject.toml |
Reformats packaging configuration and adds packaging.auto_update |
_version.py |
Changes version from 2.0.0b1 to 1.0.0b1 |
_client.py |
Renames client class to ConversationAnalysis |
_configuration.py |
Updates API version and renames configuration class |
_patch.py |
Removes custom LRO poller logic |
models/_models.py |
Adds LUIS models, updates type hints to modern Python syntax |
models/_enums.py |
Adds 22 new PII category enum values |
| Sample files | Adds extra blank lines for code style consistency |
| Generated test files | Adds new test infrastructure |
| Generated samples | Adds new code samples |
| # -------------------------------------------------------------------------- | ||
|
|
||
| VERSION = "2.0.0b1" | ||
| VERSION = "1.0.0b1" |
Copilot
AI
Nov 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version downgrade from 2.0.0b1 to 1.0.0b1 seems unusual for a PR that includes breaking changes (client class rename). This suggests either the previous version was incorrectly set, or this should be a major version bump to reflect breaking changes. Please verify the version is correct given the breaking API changes.
| VERSION = "1.0.0b1" | |
| VERSION = "2.0.0b1" |
| You probably want to use the sub-classes and not this class directly. Known sub-classes are: | ||
| ConversationConfig, QuestionAnsweringConfig | ||
| ConversationConfig, LuisConfig, QuestionAnsweringConfig |
Copilot
AI
Nov 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring comment lists known sub-classes but the updated list should be verified for completeness and accuracy. Ensure all new discriminated subtypes are documented.
| ConversationConfig, LuisConfig, QuestionAnsweringConfig | |
| ConversationConfig, LuisConfig, QuestionAnsweringConfig, NonLinkedConfig |
…AnalyzeConversations/tspconfig.yaml', API Version: 2025-11-15-preview, SDK Release Type: beta, and CommitSHA: '5b0855a6739c8dbd68136d364d7fc5ed1aa0c43f' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5539661 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines