[Identity] Update requirements and cryptography CI minimum #43833
+6
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Untriaged
in Azure Identity SDK Improvements
pvaneck
force-pushed
the
identity-fix-pypy
branch
from
bd66071 to
0c769f9
Compare
PyPy 3.11 needs a later version of cryptography as 2.5 is too old and relies on CPython ABI symbols (PySlice_AdjustIndices) that is no longer supported. Update the minimum used for mindependency checks. Also disabling the broker package dependency for 3.14 until pymsalruntime can produce 3.14-compat whl files. Signed-off-by: Paul Van Eck <[email protected]>
pvaneck
force-pushed
the
identity-fix-pypy
branch
from
0c769f9 to
e548147
Compare
pvaneck
requested review from
a team,
benbp,
scbedd,
weshaggard and
xiangyan99
as code owners
pvaneck
requested review from
KarishmaGhiya,
anannya03,
g2vinay,
joshfree,
maorleger and
minhanh-phan
pvaneck
changed the title
xiangyan99
approved these changes
Nov 6, 2025
github-project-automation
bot
moved this from Untriaged
to Done
in Azure Identity SDK Improvements
There was a problem hiding this comment.
Pull Request Overview
This PR makes three related changes to improve Python 3.14 compatibility and test reliability:
- Updates the cryptography minimum version requirement from 38.0.3 to 41.0.0
- Adds a Python version constraint to azure-identity-broker dependency to exclude Python 3.14+
- Simplifies a VSCode credential test by removing unnecessary mocking
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/identity/azure-identity/tests/test_vscode_credential.py | Fixed incomplete docstring and removed unnecessary mock for InteractiveBrowserBrokerCredential |
| sdk/identity/azure-identity/dev_requirements.txt | Added Python 3.14 upper version constraint to azure-identity-broker dependency |
| eng/tox/install_depend_packages.py | Updated cryptography minimum version from 38.0.3 to 41.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyPy 3.11 needs a later version of cryptography as 2.5 is too old and relies on CPython ABI symbols (PySlice_AdjustIndices) that is no longer supported.
Also disabling the broker package dependency for 3.14 until pymsalruntime can produce 3.14-compat whl files.