Skip to content

Conversation

@YoYoJa
Copy link
Contributor

@YoYoJa YoYoJa commented Nov 6, 2025

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copilot AI review requested due to automatic review settings November 6, 2025 21:17
@YoYoJa YoYoJa requested a review from a team as a code owner November 6, 2025 21:17
@github-actions github-actions bot added the Evaluation Issues related to the client library for Azure AI Evaluation label Nov 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds null/NaN safety checks to evaluation summary calculation logic. The changes ensure that null or NaN values in model usage statistics and testing criteria results are properly handled rather than causing errors or corrupting summary data.

Key changes:

  • Added _is_none_or_nan() checks before accumulating token counts and criteria statistics
  • Refactored inline conditional expressions into explicit variable assignments with null/NaN validation
  • Updated test data to reflect proper handling of null values in evaluation results

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
_evaluate.py Added null/NaN safety checks for model_name, token counts, and testing criteria statistics
evaluation_util_convert_old_output_test.jsonl Updated test data with additional violence evaluator fields and sample data
evaluation_util_convert_expected_output.json Updated expected output to include new fields and corrected error message percentages
evaluation_util_convert_error_summary.json Updated error summary to reflect partial completion (50% vs 100% failure)

@YoYoJa YoYoJa merged commit 9ceb7da into main Nov 6, 2025
20 checks passed
@YoYoJa YoYoJa deleted the jessli/UpdateMappings branch November 6, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Evaluation Issues related to the client library for Azure AI Evaluation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants