Found certain cases isinstance not reliable for annotaiton. So I now… #43855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howieleung
requested review from
dargilco,
glharper,
nick863 and
trangevi
as code owners
dargilco
approved these changes
Nov 6, 2025
sdk/ai/azure-ai-projects/samples/agents/tools/sample_agent_bing_grounding.py
Outdated
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/samples/agents/tools/sample_agent_bing_grounding.py
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/samples/agents/tools/sample_agent_code_interpreter.py
Show resolved
Hide resolved
nick863
approved these changes
Nov 7, 2025
…check type instead to be a universal solution. Added bing grounding. Retest all streaming.
howieleung
force-pushed
the
howie/bing-and-more
branch
from
e4d8887 to
06071cb
Compare
howieleung
merged commit 08161f6
into
feature/azure-ai-projects/2.0.0b1
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found certain cases isinstance not reliable for annotaiton. So I now check type instead to be a universal solution. Added bing grounding. Retest all streaming.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines