Skip to content

[Storage] Fix 100 Live Tests #44108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Storage] Fix 100 Live Tests #44108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4589c6a
Fixed queue user delegation oid
weirongw23-msft Nov 19, 2025
321b3ba
Blob tags conditional headers
weirongw23-msft Nov 19, 2025
3ef4488
black
weirongw23-msft Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-blob/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "python",
"TagPrefix": "python/storage/azure-storage-blob",
"Tag": "python/storage/azure-storage-blob_c54a27449c"
"Tag": "python/storage/azure-storage-blob_a28cdfc889"
}
4 changes: 1 addition & 3 deletions sdk/storage/azure-storage-blob/tests/test_blob_tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,9 +536,7 @@ def test_blob_tags_conditional_headers(self, **kwargs):
blob_name = self._get_blob_reference()
blob = self.bsc.get_blob_client(self.container_name, blob_name)
first_resp = blob.upload_blob(b"abc123", overwrite=True)
early = self.get_datetime_variable(
variables, 'expiry_time', datetime.utcnow()
)
early = self.get_datetime_variable(variables, 'early', datetime.utcnow())
first_tags = {"tag1": "firsttag", "tag2": "secondtag", "tag3": "thirdtag"}
second_tags = {"tag4": "fourthtag", "tag5": "fifthtag", "tag6": "sixthtag"}

Expand Down
4 changes: 1 addition & 3 deletions sdk/storage/azure-storage-blob/tests/test_blob_tags_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,9 +447,7 @@ async def test_blob_tags_conditional_headers(self, **kwargs):
blob_name = self._get_blob_reference()
blob = self.bsc.get_blob_client(self.container_name, blob_name)
first_resp = await blob.upload_blob(b"abc123", overwrite=True)
early = self.get_datetime_variable(
variables, 'expiry_time', datetime.utcnow()
)
early = self.get_datetime_variable(variables, 'early', datetime.utcnow())
first_tags = {"tag1": "firsttag", "tag2": "secondtag", "tag3": "thirdtag"}
second_tags = {"tag4": "fourthtag", "tag5": "fifthtag", "tag6": "sixthtag"}

Expand Down
6 changes: 3 additions & 3 deletions sdk/storage/azure-storage-queue/tests/test_queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1465,7 +1465,7 @@ def test_get_user_delegation_sas(self, **kwargs):

@pytest.mark.live_test_only
@QueuePreparer()
def test_user_delegation_oid(self, **kwargs):
def test_queue_user_delegation_oid(self, **kwargs):
storage_account_name = kwargs.pop("storage_account_name")
storage_account_key = kwargs.pop("storage_account_key")
message = "addedmessage"
Expand All @@ -1487,7 +1487,7 @@ def test_user_delegation_oid(self, **kwargs):
queue.account_name,
queue.queue_name,
storage_account_key,
permission=QueueSasPermissions(add=True),
permission=QueueSasPermissions(add=True, read=True, process=True),
expiry=expiry,
user_delegation_key=user_delegation_key,
user_delegation_oid=user_delegation_oid,
Expand All @@ -1497,7 +1497,7 @@ def test_user_delegation_oid(self, **kwargs):
queue_msg = queue_client.send_message(message)
assert queue_msg is not None

result = next(queue.receive_messages())
result = next(queue_client.receive_messages())
assert message == result.content


Expand Down
10 changes: 4 additions & 6 deletions sdk/storage/azure-storage-queue/tests/test_queue_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1483,7 +1483,7 @@ async def test_get_user_delegation_sas(self, **kwargs):

@pytest.mark.live_test_only
@QueuePreparer()
async def test_user_delegation_oid(self, **kwargs):
async def test_queue_user_delegation_oid(self, **kwargs):
storage_account_name = kwargs.pop("storage_account_name")
storage_account_key = kwargs.pop("storage_account_key")
message = "addedmessage"
Expand All @@ -1505,7 +1505,7 @@ async def test_user_delegation_oid(self, **kwargs):
queue.account_name,
queue.queue_name,
storage_account_key,
permission=QueueSasPermissions(add=True),
permission=QueueSasPermissions(add=True, read=True, process=True),
expiry=expiry,
user_delegation_key=user_delegation_key,
user_delegation_oid=user_delegation_oid,
Expand All @@ -1515,12 +1515,10 @@ async def test_user_delegation_oid(self, **kwargs):
queue_msg = await queue_client.send_message(message)
assert queue_msg is not None

result = anext(queue.receive_messages())
assert message == result.content

messages = []
async for m in queue.receive_messages():
async for m in queue_client.receive_messages():
messages.append(m)
assert messages is not None
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assertion assert messages is not None will always pass since messages is initialized as an empty list and will never be None. Consider either removing this assertion or changing it to assert len(messages) > 0 to verify that at least one message was received.

Suggested change
assert messages is not None
assert len(messages) > 0

Copilot uses AI. Check for mistakes.
assert message == messages[0].content


Expand Down
Loading