-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Resolving next-pylint issues for azure-ai-ml sdk #44113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ZubaeyrMSFT
wants to merge
2
commits into
Azure:main
Choose a base branch
from
ZubaeyrMSFT:zmohammed/pylint-upgrade-i
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot finished reviewing on behalf of
ZubaeyrMSFT
November 20, 2025 06:57
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR resolves pylint issues in the azure-ai-ml SDK by improving code style and simplifying error handling. The changes focus on import statement ordering, adjusting log levels, and removing redundant try-except blocks.
Key Changes:
- Alphabetized import statements to follow PEP 8 conventions
- Changed log levels from warning/error to debug in exception handlers
- Simplified error handling by removing try-except blocks in create_or_update, archive, and restore methods
sdk/ml/azure-ai-ml/azure/ai/ml/operations/_deployment_template_operations.py
Show resolved
Hide resolved
sdk/ml/azure-ai-ml/azure/ai/ml/operations/_deployment_template_operations.py
Show resolved
Hide resolved
sdk/ml/azure-ai-ml/azure/ai/ml/operations/_deployment_template_operations.py
Show resolved
Hide resolved
sdk/ml/azure-ai-ml/azure/ai/ml/operations/_deployment_template_operations.py
Show resolved
Hide resolved
sdk/ml/azure-ai-ml/azure/ai/ml/operations/_deployment_template_operations.py
Show resolved
Hide resolved
sdk/ml/azure-ai-ml/azure/ai/ml/operations/_deployment_template_operations.py
Show resolved
Hide resolved
sdk/ml/azure-ai-ml/azure/ai/ml/operations/_deployment_template_operations.py
Show resolved
Hide resolved
achauhan-scc
approved these changes
Nov 21, 2025
kshitij-microsoft
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolving next-pylint issues for azure-ai-ml SDK.
ISSUE #43635 : azure-ai-ml needs linting updates for pylint version 3.3.6
These are the pylint issues that I had to fix. Each of my changes fall in some of the below categories:
do-not-log-exceptions-if-not-debug: Do not log exceptions in levels other than debug, it can otherwise reveal sensitive information.
do-not-log-raised-errors: Do not log an exception that you re-raise as is
try-except-raise: The except handler raises immediately (basically doing nothing in catch statement and reraising the error)
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines