Skip to content

next-mypy fixes azure-ai-ml sdk #44132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+157 −109
Open

next-mypy fixes azure-ai-ml sdk #44132

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc07d34
next-mypy fixes for automl in azure-ai-ml sdk
Nov 21, 2025
d1cc8e3
remainging next mypy issues fix
Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ml/azure-ai-ml/azure/ai/ml/entities/_job/automl/image/automl_image_classification_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ def training_parameters(self) -> Optional[ImageModelSettingsClassification]:
return self._training_parameters

@training_parameters.setter
def training_parameters(self, value: Union[Dict, ImageModelSettingsClassification]) -> None:
def training_parameters(self, value: Optional[Union[Dict, ImageModelSettingsClassification]]) -> None:
"""Setting Image training parameters for AutoML Image Classification and Image Classification Multilabel tasks.

:param value: Training parameters for AutoML Image Classification and Image Classification Multilabel tasks.
:type value: Union[Dict, ~azure.ai.ml.automl.ImageModelSettingsClassification]
:type value: Optional[Union[Dict, ~azure.ai.ml.automl.ImageModelSettingsClassification]]
:raises ~azure.ml.exceptions.ValidationException if value is not a dictionary or
ImageModelSettingsClassification.
:return: None
Expand Down
2 changes: 1 addition & 1 deletion .../azure-ai-ml/azure/ai/ml/entities/_job/automl/image/automl_image_object_detection_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def training_parameters(self) -> Optional[ImageModelSettingsObjectDetection]:
return self._training_parameters

@training_parameters.setter
def training_parameters(self, value: Union[Dict, ImageModelSettingsObjectDetection]) -> None:
def training_parameters(self, value: Optional[Union[Dict, ImageModelSettingsObjectDetection]]) -> None:
if value is None:
self._training_parameters = None
elif isinstance(value, ImageModelSettingsObjectDetection):
Expand Down
2 changes: 1 addition & 1 deletion sdk/ml/azure-ai-ml/azure/ai/ml/entities/_job/automl/nlp/automl_nlp_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def training_parameters(self) -> Optional[NlpFixedParameters]:
return self._training_parameters

@training_parameters.setter
def training_parameters(self, value: Union[Dict, NlpFixedParameters]) -> None:
def training_parameters(self, value: Optional[Union[Dict, NlpFixedParameters]]) -> None:
if value is None:
self._training_parameters = None
elif isinstance(value, NlpFixedParameters):
Expand Down
2 changes: 1 addition & 1 deletion sdk/ml/azure-ai-ml/azure/ai/ml/entities/_job/automl/tabular/classification_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def training(self) -> ClassificationTrainingSettings:
return self._training or ClassificationTrainingSettings()

@training.setter
def training(self, value: Union[Dict, ClassificationTrainingSettings]) -> None: # pylint: disable=unused-argument
def training(self, value: Union[Dict, TrainingSettings]) -> None: # pylint: disable=unused-argument
...

def _to_rest_object(self) -> JobBase:
Expand Down
4 changes: 2 additions & 2 deletions sdk/ml/azure-ai-ml/azure/ai/ml/entities/_job/automl/tabular/featurization_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def transformer_params(self) -> Optional[Dict[str, List[ColumnTransformer]]]:
return self._transformer_params

@transformer_params.setter
def transformer_params(self, value: Dict[str, List[ColumnTransformer]]) -> None:
def transformer_params(self, value: Optional[Dict[str, List[ColumnTransformer]]]) -> None:
self._transformer_params = (
None
if not value
Expand All @@ -114,7 +114,7 @@ def blocked_transformers(self) -> Optional[List[Union[BlockedTransformers, str]]
return self._blocked_transformers

@blocked_transformers.setter
def blocked_transformers(self, blocked_transformers_list: List[Union[BlockedTransformers, str]]) -> None:
def blocked_transformers(self, blocked_transformers_list: Optional[List[Union[BlockedTransformers, str]]]) -> None:
self._blocked_transformers = (
None
if blocked_transformers_list is None
Expand Down
4 changes: 2 additions & 2 deletions sdk/ml/azure-ai-ml/azure/ai/ml/entities/_job/automl/tabular/forecasting_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from azure.ai.ml.entities._job.automl.tabular.featurization_settings import TabularFeaturizationSettings
from azure.ai.ml.entities._job.automl.tabular.forecasting_settings import ForecastingSettings
from azure.ai.ml.entities._job.automl.tabular.limit_settings import TabularLimitSettings
from azure.ai.ml.entities._job.automl.training_settings import ForecastingTrainingSettings
from azure.ai.ml.entities._job.automl.training_settings import ForecastingTrainingSettings, TrainingSettings
from azure.ai.ml.entities._util import load_from_dict


Expand Down Expand Up @@ -101,7 +101,7 @@ def training(self) -> ForecastingTrainingSettings:
return self._training or ForecastingTrainingSettings()

@training.setter
def training(self, value: Union[Dict, ForecastingTrainingSettings]) -> None: # pylint: disable=unused-argument
def training(self, value: Union[Dict, TrainingSettings]) -> None: # pylint: disable=unused-argument
...

@property
Expand Down
4 changes: 2 additions & 2 deletions sdk/ml/azure-ai-ml/azure/ai/ml/entities/_job/automl/tabular/regression_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from azure.ai.ml.entities._credentials import _BaseJobIdentityConfiguration
from azure.ai.ml.entities._job._input_output_helpers import from_rest_data_outputs, to_rest_data_outputs
from azure.ai.ml.entities._job.automl.tabular import AutoMLTabular, TabularFeaturizationSettings, TabularLimitSettings
from azure.ai.ml.entities._job.automl.training_settings import RegressionTrainingSettings
from azure.ai.ml.entities._job.automl.training_settings import RegressionTrainingSettings, TrainingSettings
from azure.ai.ml.entities._util import load_from_dict


Expand Down Expand Up @@ -74,7 +74,7 @@ def training(self) -> RegressionTrainingSettings:
return self._training or RegressionTrainingSettings()

@training.setter
def training(self, value: Union[Dict, RegressionTrainingSettings]) -> None: # pylint: disable=unused-argument
def training(self, value: Union[Dict, TrainingSettings]) -> None: # pylint: disable=unused-argument
...

def _to_rest_object(self) -> JobBase:
Expand Down
24 changes: 18 additions & 6 deletions sdk/ml/azure-ai-ml/azure/ai/ml/entities/_job/automl/training_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,9 @@ def allowed_training_algorithms(self) -> Optional[List]:
return self._allowed_training_algorithms

@allowed_training_algorithms.setter
def allowed_training_algorithms(self, allowed_model_list: Union[List[str], List[ClassificationModels]]) -> None:
def allowed_training_algorithms(
self, allowed_model_list: Optional[Union[List[str], List[ClassificationModels]]]
) -> None:
self._allowed_training_algorithms = (
None
if allowed_model_list is None
Expand All @@ -202,7 +204,9 @@ def blocked_training_algorithms(self) -> Optional[List]:
return self._blocked_training_algorithms

@blocked_training_algorithms.setter
def blocked_training_algorithms(self, blocked_model_list: Union[List[str], List[ClassificationModels]]) -> None:
def blocked_training_algorithms(
self, blocked_model_list: Optional[Union[List[str], List[ClassificationModels]]]
) -> None:
self._blocked_training_algorithms = (
None
if blocked_model_list is None
Expand Down Expand Up @@ -253,7 +257,9 @@ def allowed_training_algorithms(self) -> Optional[List]:
return self._allowed_training_algorithms

@allowed_training_algorithms.setter
def allowed_training_algorithms(self, allowed_model_list: Union[List[str], List[ForecastingModels]]) -> None:
def allowed_training_algorithms(
self, allowed_model_list: Optional[Union[List[str], List[ForecastingModels]]]
) -> None:
self._allowed_training_algorithms = (
None if allowed_model_list is None else [ForecastingModels[camel_to_snake(o)] for o in allowed_model_list]
)
Expand All @@ -263,7 +269,9 @@ def blocked_training_algorithms(self) -> Optional[List]:
return self._blocked_training_algorithms

@blocked_training_algorithms.setter
def blocked_training_algorithms(self, blocked_model_list: Union[List[str], List[ForecastingModels]]) -> None:
def blocked_training_algorithms(
self, blocked_model_list: Optional[Union[List[str], List[ForecastingModels]]]
) -> None:
self._blocked_training_algorithms = (
None if blocked_model_list is None else [ForecastingModels[camel_to_snake(o)] for o in blocked_model_list]
)
Expand Down Expand Up @@ -312,7 +320,9 @@ def allowed_training_algorithms(self) -> Optional[List]:
return self._allowed_training_algorithms

@allowed_training_algorithms.setter
def allowed_training_algorithms(self, allowed_model_list: Union[List[str], List[ForecastingModels]]) -> None:
def allowed_training_algorithms(
self, allowed_model_list: Optional[Union[List[str], List[ForecastingModels]]]
) -> None:
self._allowed_training_algorithms = (
None if allowed_model_list is None else [RegressionModels[camel_to_snake(o)] for o in allowed_model_list]
)
Expand All @@ -322,7 +332,9 @@ def blocked_training_algorithms(self) -> Optional[List]:
return self._blocked_training_algorithms

@blocked_training_algorithms.setter
def blocked_training_algorithms(self, blocked_model_list: Union[List[str], List[ForecastingModels]]) -> None:
def blocked_training_algorithms(
self, blocked_model_list: Optional[Union[List[str], List[ForecastingModels]]]
) -> None:
self._blocked_training_algorithms = (
None if blocked_model_list is None else [RegressionModels[camel_to_snake(o)] for o in blocked_model_list]
)
Expand Down
Loading