Skip to content

Conversation

@dargilco
Copy link
Member

@dargilco dargilco commented Nov 22, 2025

Agent telemetry tests that have network calls from both AIProjectClient and OpenAI client are still skipped in the pipeline, since this is not yet supported.

With this change, we have many more Agent telemetry tests running in the pipeline:

tests\agents\telemetry\test_ai_agents_instrumentor.py .................                                                                                                                                                                                                                                                                      
tests\agents\telemetry\test_ai_agents_instrumentor_async.py ....                                                                                                                                                                                                                                                                             
tests\agents\telemetry\test_responses_instrumentor.py ..........................ssssss........................ssss                                                                                                                                                                                                  
tests\agents\telemetry\test_responses_instrumentor_async.py ....ss........................ssss                                                                                                                                                                                                                                               
tests\agents\telemetry\test_responses_instrumentor_metrics.py .....        

Thank you @M-Hietala for all these tests.

Also, unrelated, run 'black' tool to fix formatting in samples.

Copilot AI review requested due to automatic review settings November 22, 2025 04:29
Copilot finished reviewing on behalf of dargilco November 22, 2025 04:32
@dargilco dargilco requested a review from M-Hietala November 22, 2025 04:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables test recording for Agent telemetry tests that previously only made OpenAI network calls. The changes replace the standard recording decorators with httpx-specific decorators and remove skip markers that were blocking execution of these tests.

Key changes:

  • Replaces @recorded_by_proxy with @recorded_by_proxy_httpx for synchronous tests and @recorded_by_proxy_async with @recorded_by_proxy_async_httpx for asynchronous tests
  • Removes @pytest.mark.skip decorators from 58 test methods across three test files
  • Updates test assets tag to reflect new recordings

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
test_responses_instrumentor_metrics.py Updates 5 metrics tests to use httpx recording decorator and enables them by removing skip markers; adds import for the httpx-specific decorator
test_responses_instrumentor_async.py Updates 27 async telemetry tests to use httpx recording decorator and enables them by removing skip markers; adds import for the async httpx-specific decorator
test_responses_instrumentor.py Updates 31 sync telemetry tests to use httpx recording decorator and enables them by removing skip markers; adds import for the httpx-specific decorator
assets.json Updates the test recordings tag to the new version containing recordings for the newly enabled tests

@dargilco dargilco self-assigned this Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants