Add test recordings to all Agent telemetry tests that have OpenAI only network calls #44148
+79
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dargilco
requested review from
glharper,
howieleung,
kingernupur,
nick863,
trangevi and
trrwilson
as code owners
Copilot finished reviewing on behalf of
dargilco
November 22, 2025 04:32
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables test recording for Agent telemetry tests that previously only made OpenAI network calls. The changes replace the standard recording decorators with httpx-specific decorators and remove skip markers that were blocking execution of these tests.
Key changes:
- Replaces
@recorded_by_proxywith@recorded_by_proxy_httpxfor synchronous tests and@recorded_by_proxy_asyncwith@recorded_by_proxy_async_httpxfor asynchronous tests - Removes
@pytest.mark.skipdecorators from 58 test methods across three test files - Updates test assets tag to reflect new recordings
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test_responses_instrumentor_metrics.py |
Updates 5 metrics tests to use httpx recording decorator and enables them by removing skip markers; adds import for the httpx-specific decorator |
test_responses_instrumentor_async.py |
Updates 27 async telemetry tests to use httpx recording decorator and enables them by removing skip markers; adds import for the async httpx-specific decorator |
test_responses_instrumentor.py |
Updates 31 sync telemetry tests to use httpx recording decorator and enables them by removing skip markers; adds import for the httpx-specific decorator |
assets.json |
Updates the test recordings tag to the new version containing recordings for the newly enabled tests |
sdk/ai/azure-ai-projects/tests/agents/telemetry/test_responses_instrumentor_metrics.py
Outdated
Show resolved
Hide resolved
howieleung
approved these changes
Nov 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agent telemetry tests that have network calls from both AIProjectClient and OpenAI client are still skipped in the pipeline, since this is not yet supported.
With this change, we have many more Agent telemetry tests running in the pipeline:
Thank you @M-Hietala for all these tests.
Also, unrelated, run 'black' tool to fix formatting in samples.