[Core] Update for next-mypy #44557
Open
[Core] Update for next-mypy #44557
+17
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvaneck
force-pushed
the
core-next-mypy
branch
from
9249053 to
befbbc5
Compare
pvaneck
requested review from
annatisch,
iscai-msft,
johanste,
kashifkhan,
lmazuel and
xiangyan99
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates type annotations in azure-core and corehttp to resolve next-mypy compatibility issues. The changes include making the encoding setter parameter properly typed as Optional[str] (aligning with the property getter's return type), and adding assertions to ensure session is not None after calling open() in async transport implementations.
Key changes:
- Updated
encodingsetter parameter type fromstrtoOptional[str]in both azure-core and corehttp - Added assertions in async transport classes to satisfy mypy's type checking for session usage
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/core/corehttp/corehttp/rest/_http_response_impl.py | Updated encoding setter parameter type to Optional[str] and corresponding documentation |
| sdk/core/azure-core/azure/core/rest/_http_response_impl.py | Updated encoding setter parameter type to Optional[str] and corresponding documentation |
| sdk/core/azure-core/azure/core/pipeline/transport/_requests_trio.py | Added assertion after open() to ensure session is not None for mypy |
| sdk/core/azure-core/azure/core/pipeline/transport/_requests_asyncio.py | Added assertion after open() to ensure session is not None for mypy |
This updates azure-core and corehttp to pass the next-mypy checks. Signed-off-by: Paul Van Eck <[email protected]>
pvaneck
force-pushed
the
core-next-mypy
branch
from
befbbc5 to
300e7df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates azure-core and corehttp to pass the next-mypy checks.
Closes: #43506
Closes: #43505