[Core] Update for next-pylint #44566
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Van Eck <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses pylint 3.3.6 compatibility issues across three core libraries (azure-core, azure-core-experimental, and corehttp) to meet the January 12, 2026 deadline. The changes primarily address new pylint warnings related to exception logging and import rules.
Key changes:
- Removes exception details from warning log messages in error handling code across multiple transport implementations
- Adds pylint disable comments for new rules (
do-not-log-exceptions-if-not-debug,networking-import-outside-azure-core-transport,abstract-method) - Reformats class definition to accommodate pylint disable comment
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/core/corehttp/corehttp/transport/requests/_requests_basic.py | Removes exception details from warning logs for ChunkedEncodingError handling |
| sdk/core/corehttp/corehttp/runtime/policies/_distributed_tracing.py | Adds pylint disable comment to preserve exception details in warning log |
| sdk/core/corehttp/corehttp/rest/_requests_basic.py | Removes exception details from warning logs in stream download error handling |
| sdk/core/corehttp/corehttp/rest/_httpx.py | Removes exception details from warning logs and unused exception variables |
| sdk/core/corehttp/corehttp/rest/_aiohttp.py | Removes exception details from warning logs and unused exception variables |
| sdk/core/azure-core/azure/core/rest/_aiohttp.py | Adds pylint disable for networking import in transport code |
| sdk/core/azure-core/azure/core/pipeline/transport/_base_async.py | Reformats class definition and adds abstract-method disable |
| sdk/core/azure-core-experimental/azure/core/experimental/transport/_httpx_async.py | Adds pylint disable for networking import in transport code |
| sdk/core/azure-core-experimental/azure/core/experimental/transport/_httpx.py | Adds pylint disable for networking import in transport code |
pvaneck
requested review from
annatisch,
iscai-msft,
johanste,
kashifkhan,
lmazuel and
xiangyan99
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #43741
Closes: #39296
Closes: #39298