Introduce new version of continuation token #44574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The test failures are in min-dep tests which use azure-core 1.32.0. They will be gone after we ship core and update core's dep version in mgmt-core . |
xiangyan99
requested review from
annatisch,
iscai-msft,
johanste,
kashifkhan,
lmazuel and
pvaneck
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces a new continuation token format for long-running operations (LRO) in azure-core, migrating from pickle-based serialization to JSON-based serialization.
Key Changes:
- Migration from pickle to JSON for continuation token serialization, improving security and cross-platform compatibility
- Introduction of versioned token format to support future migration paths
- Security improvements including filtering of sensitive headers from continuation tokens
- New helper class
_ContinuationTokenHttpResponsefor reconstructing responses from tokens
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/core/azure-core/azure/core/polling/_utils.py | New utility module with token encoding/decoding functions, header filtering, and version compatibility checks |
| sdk/core/azure-core/azure/core/polling/base_polling.py | Updated LROBasePolling to use JSON-based tokens, added _ContinuationTokenHttpResponse class, modified get_continuation_token() and from_continuation_token() methods |
| sdk/core/azure-core/azure/core/polling/_poller.py | Updated NoPolling to use new token utilities, removed pickle imports |
| sdk/core/azure-core/azure/core/_version.py | Version bump from 1.37.1 to 1.38.0 |
| sdk/core/azure-core/CHANGELOG.md | Documented breaking change in continuation token format |
| sdk/core/azure-core/TROUBLESHOOTING.md | New troubleshooting guide for continuation token compatibility issues |
| sdk/core/azure-core/tests/test_base_polling.py | Updated tests to validate JSON token format, added tests for pickle incompatibility and security features |
| sdk/core/azure-core/tests/test_polling.py | Added tests for token validation and error handling |
| sdk/core/azure-core/tests/async_tests/test_base_polling_async.py | Updated async tests to match sync changes |
| sdk/core/azure-mgmt-core/tests/test_arm_polling.py | Updated tests to validate JSON token structure |
| sdk/core/azure-mgmt-core/tests/asynctests/test_async_arm_polling.py | Updated async ARM polling tests |
| sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/polling.py | Added test server routes for continuation token testing |
lmazuel
approved these changes
Jan 8, 2026
kashifkhan
reviewed
Jan 8, 2026
kashifkhan
approved these changes
Jan 8, 2026
Co-authored-by: Kashif Khan <[email protected]>
…m/Azure/azure-sdk-for-python into update_continuation_token_version
pvaneck
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new format of the continuation token