fix live test issues #44594

amber-Chen-86 · 2026-01-08T22:15:08Z

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

Copilot

Pull request overview

This pull request aims to fix live test issues in the cognitive language SDK by modifying pipeline environment variables and test execution behavior.

Key Changes:

Separates shared environment variables into service-specific variables (conversation, authoring, text analysis) in the pipeline configuration
Marks orchestration prediction tests (sync and async) to run only in playback mode

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.

File	Description
sdk/cognitivelanguage/tests.yml	Changes environment variables from shared `$(clu-uri)` and `$(clu-key)` to service-specific variables for conversations, authoring, and text analysis endpoints
sdk/cognitivelanguage/azure-ai-language-conversations/tests/test_orchestration_prediction_async.py	Adds `@pytest.mark.playback_test_only` decorator to skip tests in live mode
sdk/cognitivelanguage/azure-ai-language-conversations/tests/test_orchestration_prediction.py	Adds `@pytest.mark.playback_test_only` decorator to skip tests in live mode

Copilot · 2026-01-08T22:25:32Z

sdk/cognitivelanguage/tests.yml

-        TEXT_ANALYSIS_KEY: $(clu-key)
+        CONVERSATIONS_ENDPOINT: $(conversation-uri)
+        CONVERSATIONS_KEY: $(conversation-key)
+        AUTHORING_ENDPOINT: $(authoring-uri)


Verify that the Azure DevOps pipeline variable $(authoring-uri) exists and is properly configured. The variable name has changed from $(clu-uri) to $(authoring-uri), which is a different naming pattern. If this variable is not defined in the pipeline configuration, tests will fail with missing credentials.

Suggested change

AUTHORING_ENDPOINT: $(authoring-uri)

AUTHORING_ENDPOINT: $(clu-uri)

Copilot · 2026-01-08T22:25:33Z

sdk/cognitivelanguage/tests.yml

+        CONVERSATIONS_ENDPOINT: $(conversation-uri)
+        CONVERSATIONS_KEY: $(conversation-key)
+        AUTHORING_ENDPOINT: $(authoring-uri)
+        AUTHORING_KEY: $(authoring-key)


Verify that the Azure DevOps pipeline variable $(authoring-key) exists and is properly configured. The variable name has changed from $(clu-key) to $(authoring-key), which is a different naming pattern. If this variable is not defined in the pipeline configuration, tests will fail with missing credentials.

Suggested change

AUTHORING_KEY: $(authoring-key)

AUTHORING_KEY: $(clu-key)

Copilot · 2026-01-08T22:25:33Z

sdk/cognitivelanguage/tests.yml

+        AUTHORING_ENDPOINT: $(authoring-uri)
+        AUTHORING_KEY: $(authoring-key)
+        TEXT_ANALYSIS_ENDPOINT: $(text_analysis-uri)
+        TEXT_ANALYSIS_KEY: $(text_analysis-key)


Verify that the Azure DevOps pipeline variable $(text_analysis-key) exists and is properly configured. The variable name has changed from $(clu-key) to $(text_analysis-key), which is a different naming pattern (note the underscore in the middle). If this variable is not defined in the pipeline configuration, tests will fail with missing credentials.

Copilot · 2026-01-08T22:25:33Z

sdk/cognitivelanguage/azure-ai-language-conversations/tests/test_orchestration_prediction.py

    ...

-
+@pytest.mark.playback_test_only


The decorator @pytest.mark.playback_test_only causes these tests to skip when running in live mode. Given that the PR title is "fix live test issues", adding this decorator seems contradictory - it prevents the tests from running live rather than fixing them.

If these tests genuinely cannot run in live mode and should only run in playback mode, this change makes sense, but the PR description should explain why. Otherwise, this may be masking the underlying issue rather than fixing it.

Suggested change

@pytest.mark.playback_test_only

Copilot · 2026-01-08T22:25:34Z

sdk/cognitivelanguage/tests.yml

-        AUTHORING_KEY: $(clu-key)
-        TEXT_ANALYSIS_ENDPOINT: $(clu-uri)
-        TEXT_ANALYSIS_KEY: $(clu-key)
+        CONVERSATIONS_ENDPOINT: $(conversation-uri)


Verify that the Azure DevOps pipeline variable $(conversation-uri) exists and is properly configured. The variable name has changed from $(clu-uri) to $(conversation-uri), which is a different naming pattern. If this variable is not defined in the pipeline configuration, tests will fail with missing credentials.

Copilot · 2026-01-08T22:25:34Z

sdk/cognitivelanguage/tests.yml

+        CONVERSATIONS_KEY: $(conversation-key)
+        AUTHORING_ENDPOINT: $(authoring-uri)
+        AUTHORING_KEY: $(authoring-key)
+        TEXT_ANALYSIS_ENDPOINT: $(text_analysis-uri)


Verify that the Azure DevOps pipeline variable $(text_analysis-uri) exists and is properly configured. The variable name has changed from $(clu-uri) to $(text_analysis-uri), which is a different naming pattern (note the underscore in the middle). If this variable is not defined in the pipeline configuration, tests will fail with missing credentials.

Copilot · 2026-01-08T22:25:34Z

sdk/cognitivelanguage/tests.yml

+        TEXT_ANALYSIS_ENDPOINT: $(text_analysis-uri)
+        TEXT_ANALYSIS_KEY: $(text_analysis-key)


There's an inconsistency in the naming convention for the Azure DevOps pipeline variables. Lines 21-24 use hyphens without underscores (e.g., conversation-uri, authoring-uri), while lines 25-26 use underscores (e.g., text_analysis-uri, text_analysis-key). This inconsistency could lead to confusion. Consider standardizing the naming convention to either use all hyphens or all underscores consistently.

Suggested change

TEXT_ANALYSIS_ENDPOINT: $(text_analysis-uri)

TEXT_ANALYSIS_KEY: $(text_analysis-key)

TEXT_ANALYSIS_ENDPOINT: $(text-analysis-uri)

TEXT_ANALYSIS_KEY: $(text-analysis-key)

Copilot · 2026-01-08T22:25:34Z

...gnitivelanguage/azure-ai-language-conversations/tests/test_orchestration_prediction_async.py

        return ConversationAnalysisClient(endpoint, credential)

-
+@pytest.mark.playback_test_only


The decorator @pytest.mark.playback_test_only causes these tests to skip when running in live mode. Given that the PR title is "fix live test issues", adding this decorator seems contradictory - it prevents the tests from running live rather than fixing them.

If these tests genuinely cannot run in live mode and should only run in playback mode, this change makes sense, but the PR description should explain why. Otherwise, this may be masking the underlying issue rather than fixing it.

Suggested change

@pytest.mark.playback_test_only

Copilot · 2026-01-08T22:25:35Z

sdk/cognitivelanguage/tests.yml

-        TEXT_ANALYSIS_ENDPOINT: $(clu-uri)
-        TEXT_ANALYSIS_KEY: $(clu-key)
+        CONVERSATIONS_ENDPOINT: $(conversation-uri)
+        CONVERSATIONS_KEY: $(conversation-key)


Verify that the Azure DevOps pipeline variable $(conversation-key) exists and is properly configured. The variable name has changed from $(clu-key) to $(conversation-key), which is a different naming pattern. If this variable is not defined in the pipeline configuration, tests will fail with missing credentials.

Suggested change

CONVERSATIONS_KEY: $(conversation-key)

CONVERSATIONS_KEY: $(clu-key)

amber-Chen-86 added 2 commits January 8, 2026 13:50

update tests.yml

96ad091

add skip live test in conversations

541fc6d

Copilot AI review requested due to automatic review settings January 8, 2026 22:15

amber-Chen-86 requested review from ahmedaashour, bidisha-c, mikaelsitruk, quentinRobinson and sarkar-rajarshi as code owners January 8, 2026 22:15

amber-Chen-86 marked this pull request as draft January 8, 2026 22:15

github-actions bot added the Cognitive - Language label Jan 8, 2026

Copilot started reviewing on behalf of amber-Chen-86 January 8, 2026 22:15 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

amber-Chen-86 added 3 commits January 8, 2026 16:02

updated live tests for conv authoring

1e3b2d8

updated assets.json

e56b3ad

adjusted tests in text authoring

1a6c15a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix live test issues #44594

fix live test issues #44594

Uh oh!

amber-Chen-86 commented Jan 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	AUTHORING_ENDPOINT: $(authoring-uri)
	AUTHORING_ENDPOINT: $(clu-uri)

		TEXT_ANALYSIS_ENDPOINT: $(text_analysis-uri)
		TEXT_ANALYSIS_KEY: $(text_analysis-key)

		return ConversationAnalysisClient(endpoint, credential)


		@pytest.mark.playback_test_only

	CONVERSATIONS_KEY: $(conversation-key)
	CONVERSATIONS_KEY: $(clu-key)

fix live test issues #44594

Are you sure you want to change the base?

fix live test issues #44594

Uh oh!

Conversation

amber-Chen-86 commented Jan 8, 2026

Description

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant