[Storage] SAS proof-of-concept #2798
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdk/storage/azure_storage_blob/src/generated/clients/blob_client.rs
Outdated
Show resolved
Hide resolved
sdk/storage/azure_storage_blob/src/generated/clients/blob_client.rs
Outdated
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
|
I thought you folks were going to consider a builder pattern for SAS tokens? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves as a proof of concept of how to support the SAS authentication scheme.
The current implementation requires the following changes:
new()functions to not callendpoint.set_query(None);and null out query parametersjoin()which clears out all query parameters (note:join()expects a base url and path, not query parameters to be present in the base_url)Drawbacks of current design:
endpointwill be overloaded; in cases such as SAS, the only way to pass along that query parameter information is encoded in the endpointendpointdoes not always strictly represent just theendpoint, but may have query parameters