Skip to content

Simplify CODEOWNERS #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Simplify CODEOWNERS #2864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@

# Catch all for loose files in the root, which are mostly global configuration and
# should not be changed without team discussion.
/* @heaths @RickWinter @ronniegeraghty @LarryOsterman
/* @Azure/azure-sdk-rust-dev

Check failure on line 22 in .github/CODEOWNERS

View check run for this annotation

Azure Pipelines / rust - codeowners-linter - ci

.github/CODEOWNERS#L22 

.github/CODEOWNERS(22,1): error : Error(s) on line 22
Source Line: /*                       @Azure/azure-sdk-rust-dev
  -Azure/azure-sdk-rust-dev is an invalid team. Ensure the team exists and has write permissions.

# Catch all for non-code project files and unowned files | folders
/** @heaths @RickWinter @ronniegeraghty @LarryOsterman
/** @Azure/azure-sdk-rust-dev

Check failure on line 25 in .github/CODEOWNERS

View check run for this annotation

Azure Pipelines / rust - codeowners-linter - ci

.github/CODEOWNERS#L25 

.github/CODEOWNERS(25,1): error : Error(s) on line 25
Source Line: /**                      @Azure/azure-sdk-rust-dev
  -Azure/azure-sdk-rust-dev is an invalid team. Ensure the team exists and has write permissions.

# Allow service owners to approve crate version updates, which impact Cargo.lock
/Cargo.lock
Expand All @@ -32,23 +32,23 @@
##################

# GitHub integration and bot rules
/.github/ @heaths @RickWinter @ronniegeraghty @LarryOsterman
/.github/ @Azure/azure-sdk-rust-dev

Check failure on line 35 in .github/CODEOWNERS

View check run for this annotation

Azure Pipelines / rust - codeowners-linter - ci

.github/CODEOWNERS#L35 

.github/CODEOWNERS(35,1): error : Error(s) on line 35
Source Line: /.github/                @Azure/azure-sdk-rust-dev
  -Azure/azure-sdk-rust-dev is an invalid team. Ensure the team exists and has write permissions.

###########
# SDK
###########
# Catch all
/sdk/ @heaths @RickWinter @ronniegeraghty @LarryOsterman
/sdk/ @Azure/azure-sdk-rust-dev

# AzureSDKOwners: @heaths
# ServiceLabel: %Azure.Core
# PRLabel: %Azure.Core
/sdk/core/ @heaths @RickWinter @LarryOsterman
/sdk/core/ @heaths @Azure/azure-sdk-rust-dev

# AzureSDKOwners: @heaths
# ServiceLabel: %Azure.Identity
# PRLabel: %Azure.Identity
/sdk/identity/ @heaths @RickWinter @LarryOsterman @chlowell
/sdk/identity/ @chlowell @Azure/azure-sdk-rust-dev

###########
# Client SDKs
Expand All @@ -57,7 +57,7 @@
# AzureSDKOwners: @heaths
# ServiceLabel: %Storage
# PRLabel: %Storage
/sdk/storage/ @heaths @RickWinter @LarryOsterman @vincenttran-msft @jalauzon-msft
/sdk/storage/ @Azure/azure-sdk-rust-dev @vincenttran-msft @jalauzon-msft

# AzureSDKOwners: @heaths
# ServiceOwner: @Pilchie
Expand All @@ -68,12 +68,12 @@
# ServiceOwner: @Azure/azure-sdk-write-keyvault
# ServiceLabel: %KeyVault
# PRLabel: %KeyVault
/sdk/keyvault/ @Azure/azure-sdk-write-keyvault @heaths
/sdk/keyvault/ @Azure/azure-sdk-write-keyvault @Azure/azure-sdk-rust-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is overkill. I wanted to stay on here because I have traditionally owned it and using it as a sort of test for core changes.


###########
# Eng Sys
###########
/eng/ @hallipr @weshaggard @heaths @RickWinter
/eng/ @hallipr @weshaggard @Azure/azure-sdk-rust-dev
/eng/common/ @Azure/azure-sdk-eng
/.github/workflows/ @Azure/azure-sdk-eng
/.github/CODEOWNERS @RickWinter @ronniegeraghty @Azure/azure-sdk-eng
Expand Down
Loading