Listen only to stdout for test-proxy errors #2897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves Azure#2715. On Windows, listening on stderr was keeping the test-proxy process alive and it wasn't shutting down after all tests completed. There may be a better solution using PTY, but stock support in `std` or `tokio` for PTY isn't adequate in Windows and this narrow use case doesn't currently warrant the amount of effort I put into heaths/akv-cli-rs to fix a similar problem.
heaths
changed the title
LarryOsterman
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2715. On Windows, listening on stderr was keeping the test-proxy process alive and it wasn't shutting down after all tests completed. There may be a better solution using PTY, but stock support in std or okio for PTY isn't adequate in Windows and this narrow use case doesn't currently warrant the amount of effort I put into heaths/akv-cli-rs to fix a similar problem.