-
Notifications
You must be signed in to change notification settings - Fork 313
Add support for event hub transport layer proxy #3051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for your contribution @k-shlomi! We will review the pull request and get back to you soon. |
@microsoft-github-policy-service agree company="Sweet Security" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few notes, but @LarryOsterman should definitely have a look. Thanks for the contribution!
/azp run rust - eventhubs - weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I'm singularly impressed. I have one significant concern, which is that I believe that these new tests will fail in our weekly test runs because we run our tests with --all-features
and the CI pipeline doesn't have a SOCKS5 proxy available to work.
Also I'd like to have someone from the EventHubs service team take a look to confirm that they want SOCKS5 proxy support as a feature (it's complicated).
sdk/eventhubs/azure_messaging_eventhubs/examples/eventhubs_socks5_proxy.rs
Show resolved
Hide resolved
sdk/eventhubs/azure_messaging_eventhubs/tests/eventhubs_socks5_messaging.rs
Outdated
Show resolved
Hide resolved
ed8db60
to
2ece6c7
Compare
Hi @heaths and @LarryOsterman |
@weshaggard @hallipr what's going on with the vcpkg install on Windows? From the logs,
We're using the same setup that other repos are using, so did something break recently? |
@k-shlomi please address my comments as well. See our root |
@heaths I believe I did fix your comments. can you point me out to comments I missed? |
@danieljurek is investigating the vcpkg issue. |
Notes from investigation so far:
|
There was a breaking change to binary caching for vcpkg in this version. I have a fix working locally... PR coming soon |
Fix is in. Rebase on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't take direct dependencies in a crate. There are also some sanitization concerns.
727fc0d
to
93fe99f
Compare
@heaths one question for you in regards to your last comments. |
e72dc50
to
15d7ba3
Compare
I don't see a question I haven't answered already. Could you resolve PR comments as you fix/respond to them? Might be easier to see what's still considered an open issue. That's how we do it on our team. |
15d7ba3
to
99f8264
Compare
@heaths I missed your comment about making sanitize public a few days ago... fixed it now. |
Hey. I'm on the Event Hubs team that is managing this sdk going forward. Thanks a lot for this work. I'm currently speaking with our PM about how to consider this additional functionality. To integrate this change, we'd need to also add it to all of the other language SDKs (and probably the Service Bus SDKs) for parity. We're trying to determine if that (and the maintenance burden) is something we can take on. |
got it @j7nw4r thanks. |
Adds SOCKS5 proxy support for Rust EventHubs client, enabling connections through corporate proxies and restricted network environments.
Changes
Core Implementation
Dependencies
Documentation & Examples
Usage
Resolves enterprise customer requirements for proxy support in restricted network environments.