-
Notifications
You must be signed in to change notification settings - Fork 313
Getting offset and sequence number from event data rather than amqp annotations. #3148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the improper extraction of offset and sequence numbers for Event Hub checkpoints. The existing code was manually parsing AMQP message annotations to retrieve these values, which was error-prone and redundant. The fix leverages the existing accessor methods on ReceivedEventData
to directly obtain the offset and sequence number values.
- Removes manual AMQP annotation parsing logic for offset and sequence numbers
- Uses direct accessor methods
event_data.offset()
andevent_data.sequence_number()
instead - Simplifies the checkpoint update flow by removing unnecessary error handling for annotation parsing
sdk/eventhubs/azure_messaging_eventhubs/src/event_processor/partition_client.rs
Outdated
Show resolved
Hide resolved
baa20de
to
c22a587
Compare
sdk/eventhubs/azure_messaging_eventhubs/src/event_processor/partition_client.rs
Show resolved
Hide resolved
sdk/eventhubs/azure_messaging_eventhubs/src/event_processor/partition_client.rs
Show resolved
Hide resolved
… correct &str consts.
@LarryOsterman Please review. I went back to a structure similar to the original. I updated the annotation labels used to use the same labels as the |
@microsoft-github-policy-service agree company="Microsoft" |
sdk/eventhubs/azure_messaging_eventhubs/src/event_processor/partition_client.rs
Show resolved
Hide resolved
/cla help |
@microsoft-github-policy-service rerun |
1 similar comment
@microsoft-github-policy-service rerun |
/check-enforcer evaluate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this in, can we get a release out? I have #3143 in a draft state waiting on this, more or less.
This PR addresses: #3073
Properly retrieve the offset and sequence numbers to properly store checkpoints.