Skip to content

Conversation

@praveenkuttappan
Copy link
Member

PR contains changes to upgrade MCP protocol lib and changes in instrumentation tool to support implementing Metadata getter (a requirement in new lib when inheriting delegate mcp tool class).

@praveenkuttappan praveenkuttappan self-assigned this Jan 6, 2026
Copilot AI review requested due to automatic review settings January 6, 2026 15:41
@praveenkuttappan praveenkuttappan requested a review from a team as a code owner January 6, 2026 15:41
@github-actions github-actions bot added the azsdk-cli Issues related to Azure/azure-sdk-tools::tools/azsdk-cli label Jan 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the ModelContextProtocol library from version 0.3.0-preview.4 to 0.5.0-preview.1, along with corresponding updates to ModelContextProtocol.AspNetCore. The upgrade requires refactoring the InstrumentedTool class to use a traditional constructor instead of a primary constructor and implementing the required Metadata property override. Additionally, API changes in the MCP library necessitate replacing IMcpClient interface references with the concrete McpClient class and updating McpClientFactory.CreateAsync calls to McpClient.CreateAsync.

Key Changes

  • Upgraded ModelContextProtocol packages from 0.3.0/0.1.0 preview versions to 0.5.0-preview.1
  • Refactored InstrumentedTool from primary constructor to traditional constructor with explicit field initialization
  • Migrated from IMcpClient interface to concrete McpClient class throughout evaluation helpers

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Azure.Sdk.Tools.Cli.csproj Updates ModelContextProtocol and ModelContextProtocol.AspNetCore package versions to 0.5.0-preview.1
InstrumentedTool.cs Refactors from primary constructor to traditional constructor and adds required Metadata property override
Azure.Sdk.Tools.Cli.Evaluations.csproj Updates ModelContextProtocol package version to 0.5.0-preview.1
Scenario.cs Changes field type from IMcpClient interface to concrete McpClient class
TestSetup.cs Updates method signatures and factory calls to use McpClient instead of IMcpClient/McpClientFactory
ChatCompletion.cs Updates field and constructor parameter types from IMcpClient to McpClient

@praveenkuttappan praveenkuttappan requested a review from benbp January 7, 2026 22:32
@praveenkuttappan praveenkuttappan merged commit b489a63 into Azure:main Jan 8, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azsdk-cli Issues related to Azure/azure-sdk-tools::tools/azsdk-cli

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants