You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request introduces activity tracing from app server to SignalR clients. The changes include creating and managing Activity instances to trace method calls and their outcomes, enhancing the observability of the service.
ServiceLifetimeManager.cs: Updated methods like SendConnectionAsync and InvokeConnectionAsync to create and start Activity instances, and handle exceptions by setting error status and tags on the Activity. [1][2]
Method Signature Changes:
CreateMessage method in ServiceLifetimeManager.cs: Added an Activity parameter to include tracing information in the message creation process. [1][2]
Dependency Additions:
Added System.Diagnostics and Microsoft.Azure.SignalR.Internals namespaces to support activity tracing. [1][2]
These changes aim to enhance the diagnostic capabilities of the Azure SignalR service by incorporating distributed tracing, making it easier to monitor and troubleshoot the service's behavior.
This pull request introduces activity tracing from app server to SignalR clients.
This sounds like it's trying to do the last bullet in dotnet/aspnetcore#51557 (comment)
Is that correct? If so, wouldn't it be better to wait for the core SignalR library to add this support? Or will this be needed regardless?
@BrennanConroy here is the task list for SignalR service. #2182
This pr is the implementation for server to client in server SDK.
And client to server in server SDK should be supported by net 9 SignalR by default, let me validate it later.
Since we rewrite HubLifetimeManager<THub>, we need implement tracing part by ourselves.
Of cause, we can wait for SignalR server to client part ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces activity tracing from app server to SignalR clients. The changes include creating and managing
Activityinstances to trace method calls and their outcomes, enhancing the observability of the service.Tracing Enhancements:
ServiceLifetimeManagerBase.cs: IntroducedActivitycreation and management for various methods likeSendAllAsync,SendAllExceptAsync,SendConnectionAsync, etc., and added a methodCreateActivityto initializeActivityinstances. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]ServiceLifetimeManager.cs: Updated methods likeSendConnectionAsyncandInvokeConnectionAsyncto create and startActivityinstances, and handle exceptions by setting error status and tags on theActivity. [1] [2]Method Signature Changes:
CreateMessagemethod inServiceLifetimeManager.cs: Added anActivityparameter to include tracing information in the message creation process. [1] [2]Dependency Additions:
System.DiagnosticsandMicrosoft.Azure.SignalR.Internalsnamespaces to support activity tracing. [1] [2]These changes aim to enhance the diagnostic capabilities of the Azure SignalR service by incorporating distributed tracing, making it easier to monitor and troubleshoot the service's behavior.