add client invocation for management sdk#2239
Conversation
@microsoft-github-policy-service agree company="Microsoft" |
src/Microsoft.Azure.SignalR.Management/ClientInvocation/InvocationResponse.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Management/RestHubLifetimeManager.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.Azure.SignalR.E2ETests/Management/ServiceHubContextE2EFacts.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.Azure.SignalR.Management.Tests/RestHubLifetimeManagerFacts.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Management/Serialization/JsonObjectSerializerHubProtocol.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.Azure.SignalR.E2ETests/Management/ServiceHubContextE2EFacts.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Management/RestHubLifetimeManager.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.Azure.SignalR.Management.Tests/RestHubLifetimeManagerFacts.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Management/Serialization/JsonObjectSerializerHubProtocol.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Utilities/Rest/BinaryPayloadContentBuilder.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Utilities/Rest/BinaryPayloadContentBuilder.cs
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Management/RestHubLifetimeManager.cs
Outdated
Show resolved
Hide resolved
…/azure-signalr into jiezong/clientInvecation
src/Microsoft.Azure.SignalR.Common/Utilities/Rest/SimpleInvocationBinder.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Common/Utilities/Rest/SimpleInvocationBinder.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Management/RestHubLifetimeManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Management/RestHubLifetimeManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Management/RestHubLifetimeManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Management/Serialization/JsonObjectSerializerHubProtocol.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Management/Serialization/JsonObjectSerializerHubProtocol.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.SignalR.Management/Serialization/JsonObjectSerializerHubProtocol.cs
Show resolved
Hide resolved
|
PR should be blocked until the next release is done. |
| private HttpRequestMessage GenerateHttpRequest(string url, IDictionary<string, StringValues>? query, HttpMethod httpMethod, HubMessage? body, Type? typeHint) | ||
| { | ||
| var request = new HttpRequestMessage(httpMethod, GetUri(url, query)); | ||
| request.Headers.Accept.Add(new System.Net.Http.Headers.MediaTypeWithQualityHeaderValue("application/octet-stream")); |
There was a problem hiding this comment.
This is not the right place. BinaryPayloadContent already contains it.
There was a problem hiding this comment.
In the BinaryPayloadContent, we just add a contentType instead of Accept, or maybe I lost something?
There was a problem hiding this comment.
Ah I got the two mixed up. But it's still an appropriate place to put this in BinaryPayloadContent. RestClient is a general entry point, and we don't want JsonPayloadContent to receive binary response payload, right?
There was a problem hiding this comment.
This is a bit tricky here as this header is used to identify that "this request is come from ManagementSDK", so runtime will directly return raw bytes and let SDK to deserialize the result from client.
In this case, JsonPayloadContent will also receive the binary response payload
There was a problem hiding this comment.
Why does JsonPayloadContent also receive the binary response payload?
Add client invocation logic