-
Notifications
You must be signed in to change notification settings - Fork 245
Add support for transfer data Azure Files NFS <-> Azure Files SMB #3087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dphulkar-msft
merged 33 commits into
dphulkar/NFSOverRESTSupport
from
dphulkar/SupportSMBToNFSBothSide
Sep 10, 2025
Merged
Add support for transfer data Azure Files NFS <-> Azure Files SMB #3087
dphulkar-msft
merged 33 commits into
dphulkar/NFSOverRESTSupport
from
dphulkar/SupportSMBToNFSBothSide
Sep 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t multiple values
…preserve-permissions is set to false
…t multiple values
…e/azure-storage-azcopy into dphulkar/SupportSMBToNFSBothSide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR begins adapting the codebase to support transfers between Azure Files NFS and SMB by relaxing protocol checks and adding a guard in the traversal logic.
- Added a nil-check around
processStoredObject
in the file traverser - Commented out the SMB protocol validation in
flagsValidation.go
- Commented out the NFS unsupported checks in
copy.go
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
cmd/zc_traverser_file.go | Added if s != nil guard before calling processStoredObject |
cmd/flagsValidation.go | Commented out the SMB-vs-NFS compatibility validation block |
cmd/copy.go | Commented out NFS unsupported-transfer checks in copy logic |
…into dphulkar/SupportSMBToNFSBothSide
…into dphulkar/SupportSMBToNFSBothSide
…into dphulkar/SupportSMBToNFSBothSide
…e/azure-storage-azcopy into dphulkar/SupportSMBToNFSBothSide
gapra-msft
reviewed
Aug 14, 2025
wonwuakpa-msft
approved these changes
Aug 22, 2025
…into dphulkar/SupportSMBToNFSBothSide
…e/azure-storage-azcopy into dphulkar/SupportSMBToNFSBothSide
gapra-msft
reviewed
Sep 5, 2025
gapra-msft
reviewed
Sep 5, 2025
adreed-msft
approved these changes
Sep 5, 2025
…e/azure-storage-azcopy into dphulkar/SupportSMBToNFSBothSide
gapra-msft
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SMB → NFS
--preserve-symlinks: N/A fail job
--follow-symlinks: N/A fail the job
--hardlinks: N/A fail the job
NFS → SMB
Feature / Bug Fix: (Brief description of the feature or issue being addressed)
Related Links:
Issues
Team thread
Documents
[Email Subject]
Type of Change
How Has This Been Tested?
Thank you for your contribution to AzCopy!