Preview binaries shall go with a different package name #3147
Conversation
…into dphulkar/syscontainer
…into dphulkar/syscontainer
…into dphulkar/syscontainer
…into dphulkar/syscontainer
Co-authored-by: Gauri Lamunion <[email protected]>
…e-storage-azcopy into dphulkar/syscontainer
…into dphulkar/syscontainer
…into dphulkar/syscontainer
…into dphulkar/syscontainer
…e-storage-azcopy into dphulkar/syscontainer
…-storage-azcopy into dphulkar/previewRelease
…-storage-azcopy into dphulkar/previewRelease
…into dphulkar/previewRelease
dphulkar-msft
requested review from
gapra-msft,
adreed-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft,
tanyasethi-msft and
wonwuakpa-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR implements a change to use different package names for preview vs GA releases of AzCopy. The goal is to prevent customers from accidentally installing preview versions when they intend to install the latest stable release.
- Updates the version string to include a preview suffix for non-GA builds
- Modifies package generation to use "azcopy-preview" package name for preview builds
- Adds functionality to remove specific package versions from Linux repositories
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| packages.csv | Removes most Linux distribution entries, likely for testing purposes |
| common/version.go | Changes version from GA format to preview format with tilde notation |
| build-1es-pipeline.yaml | Comments out macOS builds, adds package removal functionality, and implements preview package renaming logic |
| azurePipelineTemplates/build_linux.yml | Adds logic to use "azcopy-preview" package name when version contains "preview" |
| if [[ $(azcopy_version) == *"preview"* ]]; then | ||
| azcopyBinaryName="azcopy-preview" | ||
| fi |
There was a problem hiding this comment.
The variable $(azcopy_version) should be referenced with proper shell variable syntax. It should be "${azcopy_version}" instead of $(azcopy_version) to avoid command substitution issues.
| if [[ $(azcopy_version) == *"preview"* ]]; then | |
| azcopyBinaryName="azcopy-preview" | |
| fi | |
| if [[ "${azcopy_version}" == *"preview"* ]]; then | |
| azcopyBinaryName="azcopy-preview" | |
| fi |
Copilot uses AI. Check for mistakes.
| fpm -s dir -t deb -n azcopy -C pkgDir/ \ | ||
| packageName="azcopy" | ||
| # If the version string has preview in it then packageName shall be "azcopy-preview" | ||
| if [[ `$(azcopy_version)` == *"preview"* ]]; then |
There was a problem hiding this comment.
The variable $(azcopy_version) should be referenced with proper shell variable syntax. It should be "${azcopy_version}" instead of $(azcopy_version) to avoid command substitution issues.
| if [[ `$(azcopy_version)` == *"preview"* ]]; then | |
| if [[ "${azcopy_version}" == *"preview"* ]]; then |
Copilot uses AI. Check for mistakes.
| if [[ `$(azcopy_version)` == *"preview"* ]]; then | ||
| echo "Preview binary package created" | ||
| packageName="azcopy-preview" | ||
| fi |
There was a problem hiding this comment.
The variable $(azcopy_version) should be referenced with proper shell variable syntax. It should be "${azcopy_version}" instead of $(azcopy_version) to avoid command substitution issues.
| if [[ `$(azcopy_version)` == *"preview"* ]]; then | |
| echo "Preview binary package created" | |
| packageName="azcopy-preview" | |
| fi | |
| if [[ "$(azcopy_version)" == *"preview"* ]]; then | |
| echo "Preview binary package created" | |
| packageName="azcopy-preview" | |
| fi |
Copilot uses AI. Check for mistakes.
build-1es-pipeline.yaml
Outdated
| if [[ "$arm64file" == *preview* ]]; then | ||
| cp signed/azcopy*.x86_64.deb signed/azcopy-preview-*.x86_64.deb | ||
| fi |
There was a problem hiding this comment.
This copy command uses incorrect wildcard patterns. The source pattern azcopy*.x86_64.deb will not match files that start with azcopy-preview-, and the destination pattern should not contain wildcards in a cp command.
| if [[ "$arm64file" == *preview* ]]; then | |
| cp signed/azcopy*.x86_64.deb signed/azcopy-preview-*.x86_64.deb | |
| fi | |
| if [[ "$arm64file" == *preview* ]]; then | |
| for f in signed/azcopy*.x86_64.deb; do | |
| dest="signed/azcopy-preview-${f#signed/azcopy}" | |
| cp "$f" "$dest" | |
| done | |
| fi |
Copilot uses AI. Check for mistakes.
build-1es-pipeline.yaml
Outdated
| @@ -1100,6 +1109,11 @@ extends: | |||
| mv -v "$(signed)/mariner/azcopy"*.arm64.rpm "$marinerArmFileName" | |||
| mv -v "$(signed)/mariner/azcopy"*.x86_64.rpm "$marinerAmdFileName" | |||
|
|
|||
| # if file name conatins preview in it. Create preview files for preview upload | |||
There was a problem hiding this comment.
Spelling error in comment: 'conatins' should be 'contains'.
| # if file name conatins preview in it. Create preview files for preview upload | |
| # if file name contains preview in it. Create preview files for preview upload |
Copilot uses AI. Check for mistakes.
Description
By default both preview and GA binaries go with the same package name "blobfuse2". This means if a customer tries to install the latest version, they may end up installing a preview version. We want all out customers to by default have a GA version and make a concious choice to install preview binary explicitly. To do so we are renaming our package for preview binaries to "blobfuse2-preview".
Feature / Bug Fix: (Brief description of the feature or issue being addressed)
Related Links:
Issues
Team thread
Documents
[Email Subject]
Type of Change
How Has This Been Tested?
Thank you for your contribution to AzCopy!