Add creation of parent directory if not existing #3149
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfgang-desalvador
requested review from
gapra-msft,
adreed-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft,
tanyasethi-msft and
wonwuakpa-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where AzCopy fails to create symlinks from blob to local storage when parent directories don't exist, particularly when using wildcards in URLs. The fix ensures parent directories are created before attempting to create the symlink.
- Adds parent directory creation check before symlink creation
- Uses existing
CreateParentDirectoryIfNotExistfunction with folder creation tracking - Includes proper error handling and reporting for directory creation failures
| err = common.CreateParentDirectoryIfNotExist(jptm.Info().Destination, jptm.GetFolderCreationTracker()) | ||
|
|
||
| if err != nil { | ||
| jptm.FailActiveSend("creating destination folder for symlink", err) |
There was a problem hiding this comment.
The variable err is being reused without checking if it was previously set. Consider using a new variable name like dirErr to avoid potential confusion and make the error handling more explicit.
Suggested change
| jptm.FailActiveSend("creating destination folder for symlink", err) | |
| dirErr := common.CreateParentDirectoryIfNotExist(jptm.Info().Destination, jptm.GetFolderCreationTracker()) | |
| if dirErr != nil { | |
| jptm.FailActiveSend("creating destination folder for symlink", dirErr) |
Copilot uses AI. Check for mistakes.
|
@wolfgang-desalvador could you please add a test in e2etest with your use case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request adds the creation/existence check flow when creating a symlink in a Blob to local scenario. This
Related Links:
Type of Change
How Has This Been Tested?
This has been tested reproducing the same flow described in the issue and confirming job didn't present failed entries