Progress LCM refactor #3150
Merged
Progress LCM refactor #3150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gapra-msft
commented
Aug 4, 2025
gapra-msft
requested review from
adreed-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft,
tanyasethi-msft and
wonwuakpa-msft
as code owners
wonwuakpa-msft
approved these changes
Aug 12, 2025
dphulkar-msft
approved these changes
Aug 14, 2025
adreed-msft
reviewed
Aug 14, 2025
adreed-msft
approved these changes
Aug 14, 2025
Yeah there still is some level of code dupe in the output builder method but we cant do much about it without breaking stuff which I am avoiding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored LCM progress method to expose a Go type instead of a string.