-
Notifications
You must be signed in to change notification settings - Fork 246
Correct incorrect folder tracker behavior #3151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug in AzCopy's folder creation tracker where state would incorrectly overlap onto the first "part" of the plan file. The fix ensures proper isolation between different job parts by including part number information in folder registration and tracking.
- Updates the folder tracker to accept and use part number information
- Replaces direct plan references with a fetch function to avoid dependency cycles
- Modifies the tracker's internal storage to use a composite index including part number
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
ste/mgr-JobPartMgr.go | Adds part number parameter to folder tracker registration |
ste/mgr-JobMgr.go | Updates folder tracker initialization to use job manager instead of plan |
ste/folderCreationTracker.go | Implements composite indexing with part numbers and fetch function pattern |
ste/folderCreationTracker_test.go | Updates test to validate proper state isolation between job parts |
Is there any way we could add a test case for this? |
Description
Wanted to burn something quick down to get myself back up to speed post vacation.
Type of Change
How Has This Been Tested?
Adjusted the existing test for the folder tracker