Skip to content

Pass POSIX Properties style to JobPartPlanFileName. Fix toCopyOptions…#3399

Open
wolfgang-desalvador wants to merge 1 commit intoAzure:mainfrom
wolfgang-desalvador:amlfs-fix-flags
Open

Pass POSIX Properties style to JobPartPlanFileName. Fix toCopyOptions…#3399
wolfgang-desalvador wants to merge 1 commit intoAzure:mainfrom
wolfgang-desalvador:amlfs-fix-flags

Conversation

@wolfgang-desalvador
Copy link
Copy Markdown

Description

This pull request introduces support for specifying and handling the POSIX properties style in copy operations. The main changes ensure that the PosixPropertiesStyle is properly parsed from user input and included in the job part plan for copy operations.

Enhancements to POSIX properties handling:

  • Added parsing of the posixPropertiesStyle option in the toCopyOptions function to validate and set the POSIX properties style during copy command processing.
  • Included the PosixPropertiesStyle field in the job part plan creation to ensure it is stored and used during job execution.… to consider POSIX Properties Style

Type of Change

  • Bug fix
  • New feature
  • Documentation update required
  • Code quality improvement
  • Other (describe):

How Has This Been Tested?

Tested on real-use case scenario, validating that now Blob is copied with correct metadata

@wolfgang-desalvador
Copy link
Copy Markdown
Author

@wonwuakpa-msft

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds end-to-end propagation of the --posix-properties-style option so the selected POSIX metadata style (e.g., amlfs) is validated at parse time and persisted into job part plans for execution/resume.

Changes:

  • Parse and validate posixPropertiesStyle in rawCopyCmdArgs.toCopyOptions so invalid values fail early and valid values are carried into azcopy.CopyOptions.
  • Persist PosixPropertiesStyle into the job part plan header when creating the plan file, so STE uses the intended style during execution.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
cmd/copy.go Parses --posix-properties-style into CopyOptions.PosixPropertiesStyle during copy command option construction.
ste/JobPartPlanFileName.go Writes PosixPropertiesStyle from the job part order into the job part plan header so STE can act on it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants