Pass POSIX Properties style to JobPartPlanFileName. Fix toCopyOptions…#3399
Open
wolfgang-desalvador wants to merge 1 commit intoAzure:mainfrom
Open
Pass POSIX Properties style to JobPartPlanFileName. Fix toCopyOptions…#3399wolfgang-desalvador wants to merge 1 commit intoAzure:mainfrom
wolfgang-desalvador wants to merge 1 commit intoAzure:mainfrom
Conversation
… to consider POSIX Properties Style
Author
Contributor
There was a problem hiding this comment.
Pull request overview
Adds end-to-end propagation of the --posix-properties-style option so the selected POSIX metadata style (e.g., amlfs) is validated at parse time and persisted into job part plans for execution/resume.
Changes:
- Parse and validate
posixPropertiesStyleinrawCopyCmdArgs.toCopyOptionsso invalid values fail early and valid values are carried intoazcopy.CopyOptions. - Persist
PosixPropertiesStyleinto the job part plan header when creating the plan file, so STE uses the intended style during execution.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cmd/copy.go |
Parses --posix-properties-style into CopyOptions.PosixPropertiesStyle during copy command option construction. |
ste/JobPartPlanFileName.go |
Writes PosixPropertiesStyle from the job part order into the job part plan header so STE can act on it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces support for specifying and handling the POSIX properties style in copy operations. The main changes ensure that the
PosixPropertiesStyleis properly parsed from user input and included in the job part plan for copy operations.Enhancements to POSIX properties handling:
posixPropertiesStyleoption in thetoCopyOptionsfunction to validate and set the POSIX properties style during copy command processing.PosixPropertiesStylefield in the job part plan creation to ensure it is stored and used during job execution.… to consider POSIX Properties StyleFeature / Bug Fix: [Bug] AMLFS POSIX Properties style is not passed down from CLI flags #3398
Related Links:
[Bug] AMLFS POSIX Properties style is not passed down from CLI flags #3398
Type of Change
How Has This Been Tested?
Tested on real-use case scenario, validating that now Blob is copied with correct metadata