Add hardlink preserve support for Download and S2S sync operation

azcopy/copy.go

@@ -177,12 +177,12 @@ func (c *Client) Copy(ctx context.Context, src, dest string, opts CopyOptions) (
 		common.LogPathFolder = ""
 	}
 
-	var t *transferExecutor
 	ctx = context.WithValue(ctx, ste.ServiceAPIVersionOverride, ste.DefaultServiceApiVersion)
 	t, err := newCopyTransferExecutor(ctx, jobID, src, dest, opts, c.GetUserOAuthTokenManagerInstance())
 	if err != nil {
 		return CopyResult{}, err
 	}
+	defer t.Close()
 
 	// handle from/to pipe
 	if t.opts.fromTo.IsRedirection() {
@@ -254,9 +254,20 @@ func (c *Client) Copy(ctx context.Context, src, dest string, opts CopyOptions) (
 }
 
 type transferExecutor struct {
-	opts *CookedTransferOptions
-	trp  *remoteProvider
-	tpt  *transferProgressTracker
+	opts       *CookedTransferOptions
+	trp        *remoteProvider
+	tpt        *transferProgressTracker
+	inodeStore *common.InodeStore
+}
+
+// Close releases resources held by the transferExecutor, including the inode store.
+func (t *transferExecutor) Close() error {
+	if t == nil || t.inodeStore == nil {
+		return nil
+	}
+	err := t.inodeStore.Close()
+	t.inodeStore = nil
+	return err
 }
 
 func newCopyTransferExecutor(ctx context.Context, jobID common.JobID, src, dst string, opts CopyOptions, uotm *common.UserOAuthTokenManager) (t *transferExecutor, err error) {
@@ -271,7 +282,12 @@ func newCopyTransferExecutor(ctx context.Context, jobID common.JobID, src, dst s
 		return nil, err
 	}
 
+	store, err := common.NewInodeStore(jobID)
+	if err != nil {
+		return nil, fmt.Errorf("failed to initialize inode store: %w", err)
+	}
+
 	progressTracker := newTransferProgressTracker(jobID, opts.Handler, cookedOpts.fromTo)
 
-	return &transferExecutor{opts: cookedOpts, trp: copyRemote, tpt: progressTracker}, nil
+	return &transferExecutor{opts: cookedOpts, trp: copyRemote, tpt: progressTracker, inodeStore: store}, nil
 }

azcopy/copyEnumerator.go

@@ -150,6 +150,7 @@ func (t *transferExecutor) initCopyEnumerator(ctx context.Context, logLevel comm
 
 		ExcludeContainers:    t.opts.excludeContainers,
 		IncrementEnumeration: t.tpt.incEnumeration,
+		InodeStore:           t.inodeStore,
 	})
 	if err != nil {
 		return nil, err

azcopy/output.go

@@ -156,6 +156,7 @@ Number of Copy Transfers Failed: %v
 Number of Deletions at Destination: %v
 Number of Symbolic Links Skipped: %v
 Number of Special Files Skipped: %v
+Number of Hardlinks Transferred: %v
 Number of Hardlinks Converted: %v
 Number of Hardlinks Skipped: %v
 Total Number of Bytes Transferred: %v
@@ -175,6 +176,7 @@ Final Job Status: %v%s%s
 		result.DeleteTransfersCompleted,
 		result.SkippedSymlinkCount,
 		result.SkippedSpecialFileCount,
+		result.HardlinksTransferCount,
 		result.HardlinksConvertedCount,
 		result.SkippedHardlinkCount,
 		result.TotalBytesTransferred,

azcopy/sync.go

@@ -24,6 +24,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"runtime"
 	"time"
 
 	"github.com/Azure/azure-storage-azcopy/v10/common"
@@ -232,9 +233,20 @@ func (c *Client) Sync(ctx context.Context, src, dest string, opts SyncOptions) (
 }
 
 type syncer struct {
-	opts *cookedSyncOptions
-	srp  *remoteProvider
-	spt  *syncProgressTracker
+	opts       *cookedSyncOptions
+	srp        *remoteProvider
+	spt        *syncProgressTracker
+	inodeStore *common.InodeStore
+}
+
+// Close releases any resources held by the syncer, including the inode store.
+func (s *syncer) Close() error {
+	if s == nil || s.inodeStore == nil {
+		return nil
+	}
+	err := s.inodeStore.Close()
+	s.inodeStore = nil
+	return err
 }
 
 func newSyncer(ctx context.Context, jobID common.JobID, src, dst string, opts SyncOptions, uotm *common.UserOAuthTokenManager) (s *syncer, err error) {
@@ -247,6 +259,17 @@ func newSyncer(ctx context.Context, jobID common.JobID, src, dst string, opts Sy
 	if err != nil {
 		return nil, err
 	}
+	store, err := common.NewInodeStore(jobID)
+	if err != nil {
+		return nil, fmt.Errorf("failed to initialize inode store: %w", err)
+	}
 	progressTracker := newSyncProgressTracker(jobID, opts.Handler)
-	return &syncer{opts: cookedOpts, srp: syncRemote, spt: progressTracker}, nil
+	sync := &syncer{opts: cookedOpts, srp: syncRemote, spt: progressTracker, inodeStore: store}
+
+	// Ensure that resources are eventually released even if the caller forgets to close the syncer.
+	runtime.SetFinalizer(sync, func(s *syncer) {
+		_ = s.Close()
+	})
+
+	return sync, nil
 }