Fix issues related to MSRC case #110341; update packages per CVE-2026-33186#3422
Open
adreed-msft wants to merge 9 commits intomainfrom
Open
Fix issues related to MSRC case #110341; update packages per CVE-2026-33186#3422adreed-msft wants to merge 9 commits intomainfrom
adreed-msft wants to merge 9 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses MSRC case #110341 / CVE-2026-33186 by hardening Linux SDDL parsing/validation to prevent crashes from maliciously crafted relative security descriptors, and updates several Go dependencies accordingly.
Changes:
- Add uint32 overflow-safe range validation during Linux SDDL parsing to prevent crashes on malformed descriptors.
- Replace panic paths in Linux local SDDL retrieval with returned errors.
- Bump multiple
golang.org/x/*and gRPC-related dependencies; add a Linux regression test and update changelog.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
ste/sourceInfoProvider-Local_linux.go |
Returns errors instead of panicking when SDDL parsing/sanity checks fail. |
sddl/sddlHelper_linux.go |
Adds overflow-safe range checks for offsets/lengths when validating/parsing relative security descriptors. |
sddl/sddlHelper_linux_test.go |
Adds a Linux regression test ensuring malicious offsets don’t crash validation/parsing. |
go.mod |
Updates vulnerable/transitive dependency versions. |
go.sum |
Records module checksum updates for dependency bumps. |
build-1es-pipeline.yaml |
Enables disableNetworkIsolation feature flag for the official 1ES pipeline template. |
ChangeLog.md |
Documents dependency updates and the Linux SDDL crash fix under 10.32.3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gapra-msft
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
How Has This Been Tested?
TestMaliciousRelativeSDDLCrashPreventedinsddl/sddlHelper_linux_test.go