Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

Commit 246dc84

Browse files
Jinming-Huvinjiang
authored andcommitted
Fix a bug in xml parser, where invalid xml message may cause hang forever
1 parent 658b418 commit 246dc84

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Microsoft.WindowsAzure.Storage/src/xml_wrapper.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ xml_text_reader_wrapper::~xml_text_reader_wrapper()
5050

5151
bool xml_text_reader_wrapper::read()
5252
{
53-
return xmlTextReaderRead(m_reader) != 0;
53+
return xmlTextReaderRead(m_reader) == 1;
5454
}
5555

5656
unsigned xml_text_reader_wrapper::get_node_type()
@@ -60,7 +60,7 @@ unsigned xml_text_reader_wrapper::get_node_type()
6060

6161
bool xml_text_reader_wrapper::is_empty_element()
6262
{
63-
return xmlTextReaderIsEmptyElement(m_reader) != 0;
63+
return xmlTextReaderIsEmptyElement(m_reader) == 1;
6464
}
6565

6666
std::string xml_text_reader_wrapper::get_local_name()
@@ -92,12 +92,12 @@ std::string xml_text_reader_wrapper::get_value()
9292

9393
bool xml_text_reader_wrapper::move_to_first_attribute()
9494
{
95-
return xmlTextReaderMoveToFirstAttribute(m_reader) != 0;
95+
return xmlTextReaderMoveToFirstAttribute(m_reader) == 1;
9696
}
9797

9898
bool xml_text_reader_wrapper::move_to_next_attribute()
9999
{
100-
return xmlTextReaderMoveToNextAttribute(m_reader) != 0;
100+
return xmlTextReaderMoveToNextAttribute(m_reader) == 1;
101101
}
102102

103103
xml_element_wrapper::~xml_element_wrapper()

0 commit comments

Comments
 (0)