[CosmosDb] Replacing scaling logs to WebJobs extension methods#975
Open
[CosmosDb] Replacing scaling logs to WebJobs extension methods#975
Conversation
mathewc
reviewed
Nov 18, 2025
| if (!TryHandleCosmosException(e)) | ||
| { | ||
| _logger.LogWarning(Events.OnScaling, "Unable to handle {0}: {1}", e.GetType().ToString(), e.Message); | ||
| _logger.LogFunctionScaleWarning("Unable to handle.", _functionId, e); |
Member
There was a problem hiding this comment.
Given the format change here, I suggest to reword to "Unable to handle exception.", or perhaps keep the wording as it was for this?
Thinking the formatted end result "Function 'Foo' warning: Unable to handle." showing up in log summaries is too vague.
mathewc
reviewed
Nov 18, 2025
| } | ||
|
|
||
| _logger.LogWarning(Events.OnScaling, errormsg); | ||
| _logger.LogFunctionScaleWarning(errormsg, _functionId, e); |
Member
There was a problem hiding this comment.
nit: while you're in here, let's fix errormsg -> errorMsg or errorMessage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.