Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1269 +/- ##
=======================================
Coverage 51.66% 51.66%
=======================================
Files 53 53
Lines 2938 2938
=======================================
Hits 1518 1518
Misses 1378 1378
Partials 42 42 ☔ View full report in Codecov by Sentry. |
660d364 to
254d115
Compare
Signed-off-by: Ray Luo <rayluo.mba@gmail.com> Signed-off-by: Monis Khan <mok@microsoft.com>
254d115 to
d80db28
Compare
enj
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The previous sample was a proof-of-concept which only worked as a one-off script, and inefficiently. Problems include:
After this PR, the sample, if being used as a long-lived daemon, will automatically attempt token search from cache, and automatically reload the assertion when cache misses.
No.
No.
Requirements
Issue Fixed:
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers:
I do not have an AKS environment to actually run this change. The repo owner shall be able to test that part.