Conversation
dem108
requested review from
Blackmist,
fbsolo-ms1,
lgayhardt,
msakande,
sdgilley and
ssalgadodev
as code owners
Contributor
Author
|
@msakande this is regarding user story 320905. please approve. "cli-scripts-deploy-rest" flow above passed successfully. "bootstrapping-infra" seems to have an issue but it's not related to this change so can be ignored. |
msakande
approved these changes
Oct 7, 2024
msakande
approved these changes
Oct 7, 2024
Contributor
msakande
left a comment
msakande
left a comment
There was a problem hiding this comment.
Docs approval - these changes will not break our build.
Contributor
Author
|
@msakande , same as before, one of the flows, the one about bootstrapping-infra, isn't related. Can we ignore it and merge this? We need one more approver needed. |
s-polly
approved these changes
Jan 14, 2025
msakande
force-pushed
the
dem108-patch-1
branch
from
bc71618 to
3855958
Compare
fbsolo-ms1
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist