-
Notifications
You must be signed in to change notification settings - Fork 531
feat: Deprecating module Microsoft.Network/frontDoors #5714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are 3 more TODOs:
- Remove the workflow file (it will fail now anyways)
- Remove the entry from the issue template & CODEOWNERS
- Remove the Teams
Thoughts, @matebarabas ?
|
@AlexanderSehr @matebarabas the docs indicate a 2 PR process, where the additional items (remove the workflow file, etc.) are done in the 2nd PR. |
Hey @hundredacres, |
|
Hey @hundredacres,
|
|
@AlexanderSehr completed the remaining steps |
ReneHezser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## Description Deprecating module. ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation - [ ] Update to CI Environment or utilities (Non-module affecting changes) ## Checklist - [X] I'm sure there are no other open Pull Requests for the same update/change - [X] I have run `Set-AVMModule` locally to generate the supporting module files. - [X] My corresponding pipelines / checks run clean and green without any errors or warnings - [ ] I have updated the module's CHANGELOG.md file with an entry for the next version <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep --> --------- Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

Description
Deprecating module.
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.