Skip to content

Conversation

@AlexanderSehr
Copy link
Collaborator

@AlexanderSehr AlexanderSehr commented Jan 14, 2026

Description

Adds a test that ensures that the conditions

  • !cancelled()
  • !(github.repository != 'Azure/bicep-registry-modules' && github.event_name != 'workflow_dispatch')

exist as a condition for the job_initialize_pipeline pipeline step.

Related to

Output for passing test

  [+] [analysis-services/server] GitHub workflow [avm.res.analysis-services.server.yml]. Should have the expected push trigger path filters. 59ms (58ms|1ms)
  [+] [analysis-services/server] GitHub workflow [avm.res.analysis-services.server.yml]. Should have a condition to run only automatically on changes in upstream main. 80ms (79ms|1ms)
  [+] [analysis-services/server] GitHub workflow [avm.res.analysis-services.server.yml]. Should only have the expected push trigger path filters. 64ms (62ms|2ms)

Output for failed test

  [+] [web/site] GitHub workflow [avm.res.web.site.yml]. Should have the expected push trigger path filters. 4ms (2ms|2ms)
  [-] [web/site] GitHub workflow [avm.res.web.site.yml]. Should have a condition to run only automatically on changes in upstream main. 27ms (25ms|2ms)
   Expected 0, because the number of missing conditions of the `job_initialize_pipeline` step should be 0, but got [!cancelled(), !(github.repository != 'Azure/bicep-registry-modules' && github.event_name != 'workflow_dispatch')]., but got 2.
   at $missingConditions.Count | Should -Be 0 -Because ('the number of missing conditions of the `job_initialize_pipeline` step should be 0, but got [{0}].' -f ($missingConditions -join ', ')), C:\dev\ip\bicep-registry-modules\Upstream-Azure\utilities\pipelines\staticValidation\compliance\module.tests.ps1:617
   at <ScriptBlock>, C:\dev\ip\bicep-registry-modules\Upstream-Azure\utilities\pipelines\staticValidation\compliance\module.tests.ps1:617
  [+] [web/site] GitHub workflow [avm.res.web.site.yml]. Should only have the expected push trigger path filters. 3ms (2ms|1ms)

Pipeline Reference

Pipeline
avm.res.analysis-services.server (should pass)
avm.res.web.site (should fail)

Type of Change

  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation
  • Update to CI Environment or utilities (Non-module affecting changes)

@AlexanderSehr AlexanderSehr self-assigned this Jan 14, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jan 14, 2026
@AlexanderSehr AlexanderSehr marked this pull request as ready for review January 15, 2026 07:19
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner January 15, 2026 07:19
@avm-organizer avm-organizer bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Jan 15, 2026
@eriqua eriqua self-assigned this Jan 15, 2026
@eriqua eriqua added Type: CI 🚀 This issue is related to the AVM CI and removed Needs: Triage 🔍 Maintainers need to triage still labels Jan 15, 2026
Copy link
Collaborator

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 70cc015 into main Jan 15, 2026
6 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/condTest branch January 15, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: CI 🚀 This issue is related to the AVM CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants