Skip to content

Bump react-dom, @types/react-dom, react, @types/react in /src/vscode-bicep-ui and bump eslint, @eslint/js in /src/playground #18942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Bump react-dom, @types/react-dom, react, @types/react in /src/vscode-bicep-ui and bump eslint, @eslint/js in /src/playground #18942

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9733ef9
Bump react-dom and @types/react-dom in /src/vscode-bicep-ui
dependabot[bot] Mar 30, 2026
9aaeb7d
Fix CI: update react and @types/react to 19.x to resolve peer depende…
Copilot Mar 30, 2026
6bd8c5b
Merge origin/main into branch, resolve conflicts
Copilot Apr 1, 2026
41637ea
Incorporate playground eslint 10.x changes from PRs #19003/#19152
Copilot Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/vscode-bicep-ui/apps/deploy-pane/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
"@testing-library/jest-dom": "^6.9.1",
"@testing-library/react": "^16.3.0",
"@testing-library/user-event": "^14.6.1",
"@types/react": "^18.3.5",
"@types/react-dom": "^18.3.0",
"@types/react": "^19.2.3",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^5.1.4",
"@vitest/coverage-v8": "^3.2.4",
"@vscode-elements/webview-playground": "^1.8.0",
Expand All @@ -36,7 +36,7 @@
"@vscode-bicep-ui/components": "^0.0.0",
"@vscode-elements/elements": "^2.4.0",
"@vscode-elements/react-elements": "^2.4.0",
"react": "^18.3.1",
"react-dom": "^18.3.1"
"react": "^19.2.4",
"react-dom": "^19.2.4"
}
}
8 changes: 4 additions & 4 deletions src/vscode-bicep-ui/apps/resource-type-explorer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,17 @@
"preview": "vite preview"
},
"devDependencies": {
"@types/react": "^18.3.5",
"@types/react-dom": "^18.3.0",
"@types/react": "^19.2.3",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^5.1.4",
"vite": "^7.0.0"
},
"dependencies": {
"@vscode-bicep-ui/components": "^0.0.0",
"@vscode-bicep-ui/messaging": "^0.0.0",
"motion": "^12.36.0",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react": "^19.2.4",
"react-dom": "^19.2.4",
"styled-components": "^6.3.11"
}
}
8 changes: 4 additions & 4 deletions src/vscode-bicep-ui/apps/visual-designer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
"preview": "vite preview"
},
"devDependencies": {
"@types/react": "^18.3.5",
"@types/react-dom": "^18.3.0",
"@types/react": "^19.2.3",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^5.1.4",
"@vscode-elements/webview-playground": "^1.1.3",
"vite": "^7.0.0"
Expand All @@ -27,8 +27,8 @@
"html-to-image": "^1.11.13",
"jotai": "^2.13.1",
"motion": "^12.36.0",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react": "^19.2.4",
"react-dom": "^19.2.4",
"styled-components": "^6.3.11"
}
}
2 changes: 1 addition & 1 deletion src/vscode-bicep-ui/apps/visual-designer/src/lib/graph/hooks/use-drag-listener.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { drag } from "d3-drag";
import { select } from "d3-selection";
import { useEffect } from "react";

export function useDragListener(ref: RefObject<HTMLDivElement>, onDrag: (dx: number, dy: number) => void) {
export function useDragListener(ref: RefObject<HTMLDivElement | null>, onDrag: (dx: number, dy: number) => void) {
const getPanZoomTransform = useGetPanZoomTransform();

useEffect(() => {
Expand Down
92 changes: 40 additions & 52 deletions src/vscode-bicep-ui/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions src/vscode-bicep-ui/packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
"d3-zoom": "^3.0.0",
"jotai": "^2.17.1",
"jotai-scope": "^0.10.0",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react": "^19.2.4",
"react-dom": "^19.2.4",
"styled-components": "^6.1.11"
},
"devDependencies": {
Expand All @@ -42,8 +42,8 @@
"@types/d3-selection": "^3.0.10",
"@types/d3-transition": "^3.0.8",
"@types/d3-zoom": "^3.0.8",
"@types/react": "^18.3.12",
"@types/react-dom": "^18.3.1",
"@types/react": "^19.2.3",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^5.1.4",
"@vitest/coverage-v8": "^3.2.4",
"@vscode/codicons": "^0.0.45",
Expand Down
2 changes: 1 addition & 1 deletion src/vscode-bicep-ui/packages/components/src/azure-icon/useAzureSvg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ async function importAzureSvg(resourceType: string): Promise<SvgComponent | unde
}

export function useAzureSvg(resourceType: string) {
const svgRef = useRef<SvgComponent>();
const svgRef = useRef<SvgComponent | undefined>(undefined);
const [loading, setLoading] = useState(false);

useEffect(() => {
Expand Down
6 changes: 3 additions & 3 deletions src/vscode-bicep-ui/packages/components/src/pan-zoom/PanZoom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { select } from "d3-selection";
import { zoom, zoomIdentity } from "d3-zoom";
import { RESET } from "jotai/utils";
import { frame } from "motion/react";
import { useEffect, useLayoutEffect, useRef } from "react";
import { useEffect, useLayoutEffect, useRef, type ReactElement } from "react";
import { panZoomControlAtom, panZoomDimensionsAtom, panZoomTransformAtom, useSetAtom } from "./atoms";

import "d3-transition";
Expand Down Expand Up @@ -62,7 +62,7 @@ type PanZoomProps = PropsWithChildren<{
* @param {number} [props.transition.duration=400] - The duration of the transition.
* @param {string} [props.className] - The CSS class name for the component.
* @param {ReactNode} props.children - The child components.
* @returns {JSX.Element} The rendered component.
* @returns {ReactElement} The rendered component.
*/
export function PanZoom({
minimumScale = 1 / 4,
Expand All @@ -71,7 +71,7 @@ export function PanZoom({
transition = { duration: 400 },
className,
children,
}: PanZoomProps): JSX.Element {
}: PanZoomProps): ReactElement {
const ref = useRef<HTMLDivElement>(null);
const setPanZoomTransform = useSetAtom(panZoomTransformAtom);
const setPanZoomDimensions = useSetAtom(panZoomDimensionsAtom);
Expand Down
6 changes: 3 additions & 3 deletions src/vscode-bicep-ui/packages/components/src/pan-zoom/PanZoomTransformed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import type { PropsWithChildren } from "react";

import { useCallback, useRef } from "react";
import { useCallback, useRef, type ReactElement } from "react";
import styled from "styled-components";
import { usePanZoomTransformListener } from "./usePanZoomTransformListener";

Expand All @@ -24,9 +24,9 @@ const $PanZoomTransformed = styled.div`
* @param {PanZoomTransformedProps} props - The component props.
* @param {string} props.className - The class name for the component.
* @param {ReactNode} props.children - The child elements of the component.
* @returns {JSX.Element} - The transformed component.
* @returns {ReactElement} - The transformed component.
*/
export function PanZoomTransformed({ className, children }: PanZoomTransformedProps): JSX.Element {
export function PanZoomTransformed({ className, children }: PanZoomTransformedProps): ReactElement {
const ref = useRef<HTMLDivElement>(null);

usePanZoomTransformListener(
Expand Down
6 changes: 3 additions & 3 deletions src/vscode-bicep-ui/packages/messaging/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@
"lint:fix": "eslint . --fix"
},
"peerDependencies": {
"react": "^18.3.1"
"react": "^19.2.4"
},
"devDependencies": {
"@testing-library/dom": "^10.4.1",
"@testing-library/react": "^16.3.0",
"@types/react": "^18.3.12",
"@types/react-dom": "^18.3.1",
"@types/react": "^19.2.3",
"@types/react-dom": "^19.2.3",
"@types/vscode-webview": "^1.57.5",
"@vitest/coverage-v8": "^3.2.4",
"happy-dom": "^20.8.9",
Expand Down
Loading