Skip to content

Bug fix for setting dml tools based on bool value as set in config #2927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
souvikghosh04 merged 14 commits into from
Nov 5, 2025
Merged

Bug fix for setting dml tools based on bool value as set in config #2927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c9948a0
Bug fix for setting dml tools based on bool value as set in config
souvikghosh04 Oct 28, 2025
e103d30
Fixed potential incorrect JSON serialization as suggessted by Github …
souvikghosh04 Oct 30, 2025
0217d75
Removed ununsed method
souvikghosh04 Oct 30, 2025
ee2cda9
Merge branch 'main' into Usr/sogh/dmltoolsconfig
souvikghosh04 Oct 30, 2025
54e1bc5
set DML tools to be enabled by default if property is not specified o…
souvikghosh04 Oct 31, 2025
747a6ee
Merge branch 'Usr/sogh/dmltoolsconfig' of https://github.com/Azure/da…
souvikghosh04 Oct 31, 2025
4761b0c
Fix snapshot verification failing tests
souvikghosh04 Oct 31, 2025
ee8326d
Merge branch 'main' into Usr/sogh/dmltoolsconfig
Aniruddh25 Oct 31, 2025
c83b741
Fix failing snapshot verification tests
souvikghosh04 Nov 1, 2025
8f9f5aa
Merge branch 'Usr/sogh/dmltoolsconfig' of https://github.com/Azure/da…
souvikghosh04 Nov 1, 2025
32084d9
Fix snapshot verification tests
souvikghosh04 Nov 1, 2025
d178e01
Set tools to true by default in constructor
souvikghosh04 Nov 4, 2025
09b36fa
Merge branch 'main' into Usr/sogh/dmltoolsconfig
Aniruddh25 Nov 4, 2025
76134b0
Update src/Config/ObjectModel/McpRuntimeOptions.cs
souvikghosh04 Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/Cli.Tests/ConfigGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,16 @@ public void TestSpecialCharactersInConnectionString()
},
""mcp"": {
""enabled"": true,
""path"": ""/mcp""
},
""path"": ""/mcp"",
""dml-tools"":{
""describe-entities"": true,
""create-record"": true,
""read-records"": true,
""update-record"": true,
""delete-record"": true,
""execute-entity"":true
}
},
""host"": {
""cors"": {
""origins"": [],
Expand Down
18 changes: 17 additions & 1 deletion ...s/EndToEndTests.TestAddingStoredProcedureWithRestMethodsAndGraphQLOperations.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,23 @@
},
Mcp: {
Enabled: true,
Path: /mcp
Path: /mcp,
DmlTools: {
AllToolsEnabled: true,
DescribeEntities: true,
CreateRecord: true,
ReadRecords: true,
UpdateRecord: true,
DeleteRecord: true,
ExecuteEntity: true,
UserProvidedAllToolsEnabled: false,
UserProvidedDescribeEntities: true,
UserProvidedCreateRecord: true,
UserProvidedReadRecords: true,
UserProvidedUpdateRecord: true,
UserProvidedDeleteRecord: true,
UserProvidedExecuteEntity: true
}
},
Host: {
Cors: {
Expand Down
18 changes: 17 additions & 1 deletion ...ndToEndTests.TestConfigGeneratedAfterAddingEntityWithSourceAsStoredProcedure.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,23 @@
},
Mcp: {
Enabled: true,
Path: /mcp
Path: /mcp,
DmlTools: {
AllToolsEnabled: true,
DescribeEntities: true,
CreateRecord: true,
ReadRecords: true,
UpdateRecord: true,
DeleteRecord: true,
ExecuteEntity: true,
UserProvidedAllToolsEnabled: false,
UserProvidedDescribeEntities: true,
UserProvidedCreateRecord: true,
UserProvidedReadRecords: true,
UserProvidedUpdateRecord: true,
UserProvidedDeleteRecord: true,
UserProvidedExecuteEntity: true
}
},
Host: {
Cors: {
Expand Down
18 changes: 17 additions & 1 deletion .../EndToEndTests.TestConfigGeneratedAfterAddingEntityWithSourceWithDefaultType.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,23 @@
},
Mcp: {
Enabled: true,
Path: /mcp
Path: /mcp,
DmlTools: {
AllToolsEnabled: true,
DescribeEntities: true,
CreateRecord: true,
ReadRecords: true,
UpdateRecord: true,
DeleteRecord: true,
ExecuteEntity: true,
UserProvidedAllToolsEnabled: false,
UserProvidedDescribeEntities: true,
UserProvidedCreateRecord: true,
UserProvidedReadRecords: true,
UserProvidedUpdateRecord: true,
UserProvidedDeleteRecord: true,
UserProvidedExecuteEntity: true
}
},
Host: {
Cors: {
Expand Down
18 changes: 17 additions & 1 deletion ...pshots/EndToEndTests.TestConfigGeneratedAfterAddingEntityWithoutIEnumerables.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,23 @@
},
Mcp: {
Enabled: true,
Path: /mcp
Path: /mcp,
DmlTools: {
AllToolsEnabled: true,
DescribeEntities: true,
CreateRecord: true,
ReadRecords: true,
UpdateRecord: true,
DeleteRecord: true,
ExecuteEntity: true,
UserProvidedAllToolsEnabled: false,
UserProvidedDescribeEntities: true,
UserProvidedCreateRecord: true,
UserProvidedReadRecords: true,
UserProvidedUpdateRecord: true,
UserProvidedDeleteRecord: true,
UserProvidedExecuteEntity: true
}
},
Host: {
Cors: {
Expand Down
18 changes: 17 additions & 1 deletion src/Cli.Tests/Snapshots/EndToEndTests.TestInitForCosmosDBNoSql.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,23 @@
},
Mcp: {
Enabled: true,
Path: /mcp
Path: /mcp,
DmlTools: {
AllToolsEnabled: true,
DescribeEntities: true,
CreateRecord: true,
ReadRecords: true,
UpdateRecord: true,
DeleteRecord: true,
ExecuteEntity: true,
UserProvidedAllToolsEnabled: false,
UserProvidedDescribeEntities: true,
UserProvidedCreateRecord: true,
UserProvidedReadRecords: true,
UserProvidedUpdateRecord: true,
UserProvidedDeleteRecord: true,
UserProvidedExecuteEntity: true
}
},
Host: {
Cors: {
Expand Down
18 changes: 17 additions & 1 deletion ...Cli.Tests/Snapshots/EndToEndTests.TestUpdatingStoredProcedureWithRestMethods.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,23 @@
},
Mcp: {
Enabled: true,
Path: /mcp
Path: /mcp,
DmlTools: {
AllToolsEnabled: true,
DescribeEntities: true,
CreateRecord: true,
ReadRecords: true,
UpdateRecord: true,
DeleteRecord: true,
ExecuteEntity: true,
UserProvidedAllToolsEnabled: false,
UserProvidedDescribeEntities: true,
UserProvidedCreateRecord: true,
UserProvidedReadRecords: true,
UserProvidedUpdateRecord: true,
UserProvidedDeleteRecord: true,
UserProvidedExecuteEntity: true
}
},
Host: {
Cors: {
Expand Down
18 changes: 17 additions & 1 deletion ...EndToEndTests.TestUpdatingStoredProcedureWithRestMethodsAndGraphQLOperations.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,23 @@
},
Mcp: {
Enabled: true,
Path: /mcp
Path: /mcp,
DmlTools: {
AllToolsEnabled: true,
DescribeEntities: true,
CreateRecord: true,
ReadRecords: true,
UpdateRecord: true,
DeleteRecord: true,
ExecuteEntity: true,
UserProvidedAllToolsEnabled: false,
UserProvidedDescribeEntities: true,
UserProvidedCreateRecord: true,
UserProvidedReadRecords: true,
UserProvidedUpdateRecord: true,
UserProvidedDeleteRecord: true,
UserProvidedExecuteEntity: true
}
},
Host: {
Cors: {
Expand Down
18 changes: 17 additions & 1 deletion src/Cli.Tests/Snapshots/InitTests.CosmosDbNoSqlDatabase.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,23 @@
},
Mcp: {
Enabled: true,
Path: /mcp
Path: /mcp,
DmlTools: {
AllToolsEnabled: true,
DescribeEntities: true,
CreateRecord: true,
ReadRecords: true,
UpdateRecord: true,
DeleteRecord: true,
ExecuteEntity: true,
UserProvidedAllToolsEnabled: true,
UserProvidedDescribeEntities: true,
UserProvidedCreateRecord: true,
UserProvidedReadRecords: true,
UserProvidedUpdateRecord: true,
UserProvidedDeleteRecord: true,
UserProvidedExecuteEntity: true
}
},
Host: {
Cors: {
Expand Down
18 changes: 17 additions & 1 deletion src/Cli.Tests/Snapshots/InitTests.CosmosDbPostgreSqlDatabase.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,23 @@
},
Mcp: {
Enabled: true,
Path: /mcp
Path: /mcp,
DmlTools: {
AllToolsEnabled: true,
DescribeEntities: true,
CreateRecord: true,
ReadRecords: true,
UpdateRecord: true,
DeleteRecord: true,
ExecuteEntity: true,
UserProvidedAllToolsEnabled: true,
UserProvidedDescribeEntities: true,
UserProvidedCreateRecord: true,
UserProvidedReadRecords: true,
UserProvidedUpdateRecord: true,
UserProvidedDeleteRecord: true,
UserProvidedExecuteEntity: true
}
},
Host: {
Cors: {
Expand Down
18 changes: 17 additions & 1 deletion ...CorrectConfigGenerationWithDifferentAuthenticationProviders_171ea8114ff71814.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,23 @@
},
Mcp: {
Enabled: true,
Path: /mcp
Path: /mcp,
DmlTools: {
AllToolsEnabled: true,
DescribeEntities: true,
CreateRecord: true,
ReadRecords: true,
UpdateRecord: true,
DeleteRecord: true,
ExecuteEntity: true,
UserProvidedAllToolsEnabled: true,
UserProvidedDescribeEntities: true,
UserProvidedCreateRecord: true,
UserProvidedReadRecords: true,
UserProvidedUpdateRecord: true,
UserProvidedDeleteRecord: true,
UserProvidedExecuteEntity: true
}
},
Host: {
Cors: {
Expand Down
18 changes: 17 additions & 1 deletion ...CorrectConfigGenerationWithDifferentAuthenticationProviders_2df7a1794712f154.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,23 @@
},
Mcp: {
Enabled: true,
Path: /mcp
Path: /mcp,
DmlTools: {
AllToolsEnabled: true,
DescribeEntities: true,
CreateRecord: true,
ReadRecords: true,
UpdateRecord: true,
DeleteRecord: true,
ExecuteEntity: true,
UserProvidedAllToolsEnabled: true,
UserProvidedDescribeEntities: true,
UserProvidedCreateRecord: true,
UserProvidedReadRecords: true,
UserProvidedUpdateRecord: true,
UserProvidedDeleteRecord: true,
UserProvidedExecuteEntity: true
}
},
Host: {
Cors: {
Expand Down
18 changes: 17 additions & 1 deletion ...CorrectConfigGenerationWithDifferentAuthenticationProviders_59fe1a10aa78899d.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,23 @@
},
Mcp: {
Enabled: true,
Path: /mcp
Path: /mcp,
DmlTools: {
AllToolsEnabled: true,
DescribeEntities: true,
CreateRecord: true,
ReadRecords: true,
UpdateRecord: true,
DeleteRecord: true,
ExecuteEntity: true,
UserProvidedAllToolsEnabled: true,
UserProvidedDescribeEntities: true,
UserProvidedCreateRecord: true,
UserProvidedReadRecords: true,
UserProvidedUpdateRecord: true,
UserProvidedDeleteRecord: true,
UserProvidedExecuteEntity: true
}
},
Host: {
Cors: {
Expand Down
18 changes: 17 additions & 1 deletion ...CorrectConfigGenerationWithDifferentAuthenticationProviders_b95b637ea87f16a7.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,23 @@
},
Mcp: {
Enabled: true,
Path: /mcp
Path: /mcp,
DmlTools: {
AllToolsEnabled: true,
DescribeEntities: true,
CreateRecord: true,
ReadRecords: true,
UpdateRecord: true,
DeleteRecord: true,
ExecuteEntity: true,
UserProvidedAllToolsEnabled: true,
UserProvidedDescribeEntities: true,
UserProvidedCreateRecord: true,
UserProvidedReadRecords: true,
UserProvidedUpdateRecord: true,
UserProvidedDeleteRecord: true,
UserProvidedExecuteEntity: true
}
},
Host: {
Cors: {
Expand Down
18 changes: 17 additions & 1 deletion ...CorrectConfigGenerationWithDifferentAuthenticationProviders_daacbd948b7ef72f.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,23 @@
},
Mcp: {
Enabled: true,
Path: /mcp
Path: /mcp,
DmlTools: {
AllToolsEnabled: true,
DescribeEntities: true,
CreateRecord: true,
ReadRecords: true,
UpdateRecord: true,
DeleteRecord: true,
ExecuteEntity: true,
UserProvidedAllToolsEnabled: true,
UserProvidedDescribeEntities: true,
UserProvidedCreateRecord: true,
UserProvidedReadRecords: true,
UserProvidedUpdateRecord: true,
UserProvidedDeleteRecord: true,
UserProvidedExecuteEntity: true
}
},
Host: {
Cors: {
Expand Down
18 changes: 17 additions & 1 deletion ...Cli.Tests/Snapshots/InitTests.GraphQLPathWithoutStartingSlashWillHaveItAdded.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,23 @@
},
Mcp: {
Enabled: true,
Path: /mcp
Path: /mcp,
DmlTools: {
AllToolsEnabled: true,
DescribeEntities: true,
CreateRecord: true,
ReadRecords: true,
UpdateRecord: true,
DeleteRecord: true,
ExecuteEntity: true,
UserProvidedAllToolsEnabled: true,
UserProvidedDescribeEntities: true,
UserProvidedCreateRecord: true,
UserProvidedReadRecords: true,
UserProvidedUpdateRecord: true,
UserProvidedDeleteRecord: true,
UserProvidedExecuteEntity: true
}
},
Host: {
Cors: {
Expand Down
Loading
Loading