Suppress SM05137 in deserialization variable replacement settings #3004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronburtle
requested review from
Alekhya-Polavarapu,
Aniruddh25,
RubenCerna2079,
anushakolan,
neeraj-sharma2592,
rusamant,
sourabh1007,
souvikghosh04 and
vadeveka
as code owners
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a CodeQL suppression comment to silence the SM05137 warning for the use of DefaultAzureCredential() in the Azure Key Vault secret client initialization. The suppression is consistent with similar suppressions already present throughout the codebase.
Key Changes:
- Added inline CodeQL suppression comment for SM05137 rule with appropriate rationale
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
aaronburtle
deleted the
dev/aaronburtle/SupressCodeQLSM50137InDeserializationVarRep
branch
github-project-automation
bot
moved this from Review In Progress
to Done
in Data API builder
aaronburtle
added a commit
that referenced
this pull request
Dec 18, 2025
) ## Why make this change? This change cherry picks the commits associated with the updating of how we do variable replacement during deserialization, adding AKV to those variables that we look for. It further includes the commits for refactoring the MCP project so that the tools have their common code shared in utility functions, and have their responses aligned. ## What is this change? Cherry picked PRs: #### Azure Key Vault Support: * #2882 * #2957 * #3004 #### MCP Refactoring: * #2986 * #2984 ## How was this tested? The PRs in question were tested against the regular test suite and had tests added to cover new code changes, as well as being manually tested e.g. mcp inspector tool. ## Sample Request(s) N/A --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Aniruddh Munde <[email protected]> Co-authored-by: Souvik Ghosh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Silences CodeQL flag.
What is this change?
Adds the suppression language to the usage of
DefaultAzureCredential()How was this tested?
Against usual test suite, no real code change, just a comment.
Sample Request(s)
N/A