Skip to content

Conversation

@anushakolan
Copy link
Contributor

Why make this change?

This is a minor PR to add architecture diagram to the AI Foundry Integration documentation.

@anushakolan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an architecture diagram to the AI Foundry Integration documentation to help visualize the SQL MCP Server integration with Azure AI Foundry. The change also removes trailing whitespace from an existing line.

  • Added architecture diagram image near the beginning of the documentation
  • Removed trailing whitespace from the introductory paragraph

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diagram should go into media folder.

@anushakolan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Collaborator

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to provide relative reference to the added image.

Copy link
Contributor

@JerryNixon JerryNixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a brief review of your arch diagram, I see there is no step 6. Perhaps it would be more easily to follow a Sequence diagram like this?

image

There are several questions from this diagram as I look more closely:

  1. Is the DAB MCP endpoint a service in Azure?
  2. Does container instances connect to the DB or the SQL MCP Server?
  3. Does the DAB MCP endpoint add the tool to the Foundry agent?
  4. Does the user upload the dab-config? Really? Or does the admin?
  5. The fetch of the config has to occur BEFORE the connect to the db, right?
  6. The endpoint would come only after the db connection, right?

Maybe something more like this?

image

Raw mermaid

sequenceDiagram
    actor Admin 
    box rgb(191,223,255) Azure SQL
        participant SQLDB as Database
    end
    box rgb(255,224,178) Storage Account
        participant Storage as File Share
    end
    box rgb(200,255,200) Container Instance
        participant DAB as SQL MCP Server
    end
    box rgb(232,211,255) MS Foundry
        participant Agent as Agent
    end
    actor User

    rect rgba(100,100,100,0.05)
        Admin->>SQLDB: Store<br/>some data
        Admin->>Storage: Upload<br/>dab-config
        Admin->>Agent: Add<br/>MCP Tool
        Admin->>DAB: Start
    end
        DAB->>Storage: Download<br/>dab-config
        DAB->>DAB: Start
    Note over DAB,Agent: Wait for user

    rect rgba(100,100,100,0.05)
      User->>Agent: Chat
      Agent->>DAB: Invoke
      DAB->>SQLDB: Query
      SQLDB-->>DAB: Data
      DAB-->>Agent: Data
      Agent-->>User: Response
    end

@Aniruddh25
Copy link
Collaborator

Aniruddh25 commented Jan 6, 2026

The second sequence diagram with Admin and User makes sense. 1 correction in that - Admin will Add MCP tool to Foundry only after the Start operation of the SQL MCP Server is completed.

Copy link
Collaborator

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All valid questions asked by Jerry in his review. Could update to the suggested sequence diagram.

@anushakolan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@anushakolan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@anushakolan anushakolan enabled auto-merge (squash) January 7, 2026 22:39
@Aniruddh25
Copy link
Collaborator

@anushakolan

Can you please answer all these questions as well:

Is the DAB MCP endpoint a service in Azure?
Does container instances connect to the DB or the SQL MCP Server?
Does the DAB MCP endpoint add the tool to the Foundry agent?
Does the user upload the dab-config? Really? Or does the admin?
The fetch of the config has to occur BEFORE the connect to the db, right?
The endpoint would come only after the db connection, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants