-
Notifications
You must be signed in to change notification settings - Fork 321
add tag to TaskScheduledEvent #1211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cgillum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit odd that we create this history event but don't expose any way for DTFx users to set it. I'm okay with this if we want to expose it via other libraries, but let's wait to merge it until we have a PR (in this repo or another repo) that actually uses the property in some end-to-end way.
|
hi @cgillum , i made more changes, can you take a look when have chance? thanks |
cgillum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried that these overloads might be accidental breaking changes. Maybe we should revert those changes and only update the history events, which is what we did in the first version of your PR.
… wangbill/atag
This reverts commit 746a2d4.
cgillum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't not read the new tests closely yet, but here is some feedback for now.
This reverts commit a74b7cc.
This reverts commit bc9eb06.
Co-authored-by: Chris Gillum <[email protected]>
This reverts commit 9e9f5a8.
|
@cgillum hi Chris, comments addressed, all tests are passing, can you take another look? thanks |
This pull request introduces a new property,
Tags, to theTaskScheduledEventclass insrc/DurableTask.Core/History/TaskScheduledEvent.cs. This property is a dictionary designed to store key-value pairs of strings, providing a flexible way to include additional metadata.Related prs:
https://github.com/microsoft/durabletask-protobuf/pull/43/files
microsoft/durabletask-dotnet#426
https://msazure.visualstudio.com/One/_git/AAPT-DTMB/pullrequest/12388270
Key Change:
Tagsproperty to theTaskScheduledEventclass. This property is anIDictionary<string, string>with a default initialization to an empty dictionary, allowing for the storage of string-based key-value metadata.