Include Exception Types at FailureDetails #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgillum
reviewed
Sep 3, 2025
nytian
commented
Sep 30, 2025
cgillum
reviewed
Oct 1, 2025
Member
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
I suggested some small simplifications and refactoring.
cgillum
approved these changes
Oct 1, 2025
cgillum
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for including custom exception properties in
FailureDetails.Customers can register the interface
IExceptionPropertiesProviderat TaskhubWorker that specifies which exception types and properties should be included.IExceptionPropertiesProvideris a property onTaskHubWorker. We pass the provider to each dispatcher and then to theTaskContext. As a result, when orchestration or activity tasks are executed, use the provided implementation at TaskContext to generateFailureDetailsto include the specified exception properties.