Skip to content

fix: Skip redundant noop status updates in crp #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ahmetb wants to merge 2 commits into from
Closed

fix: Skip redundant noop status updates in crp #1079

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1d474c
fix(crp): Skip redundant noop status updates
ahmetb Mar 13, 2025
94ac9b5
Merge branch 'main' into ahmet/status-skip
ryanzhang-oss Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions pkg/controllers/clusterresourceplacement/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (

"github.com/prometheus/client_golang/prometheus"
corev1 "k8s.io/api/core/v1"
apiequality "k8s.io/apimachinery/pkg/api/equality"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
Expand Down Expand Up @@ -198,11 +199,13 @@ func (r *Reconciler) handleUpdate(ctx context.Context, crp *fleetv1beta1.Cluster
return ctrl.Result{}, err
}

if err := r.Client.Status().Update(ctx, crp); err != nil {
klog.ErrorS(err, "Failed to update the status", "clusterResourcePlacement", crpKObj)
return ctrl.Result{}, err
if !apiequality.Semantic.DeepEqual(oldCRP.Status, crp.Status) {
Copy link
Contributor

@ryanzhang-oss ryanzhang-oss Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortuantely, this is not safe as we don't reconcile on status change

Copy link
Author

@ahmetb ahmetb Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't quite understand:

  • who else do you expect will update the status of this resource and make it out of sync?
  • why can't a periodic resync that you already have course-correct drifts eventually?

Copy link
Contributor

@ryanzhang-oss ryanzhang-oss Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Only the CRP controller changes its status but the reconcile is triggered by many other objects's status change.
  • if we rely on periodic resync to course-correct then it means the resync period needs to be reasonably short (say a min) which is something we agreed not a good practice.

We should still try to optimize the startup sequence though

if err := r.Client.Status().Update(ctx, crp); err != nil {
klog.ErrorS(err, "Failed to update the status", "clusterResourcePlacement", crpKObj)
return ctrl.Result{}, err
}
klog.V(2).InfoS("Updated the clusterResourcePlacement status", "clusterResourcePlacement", crpKObj)
}
klog.V(2).InfoS("Updated the clusterResourcePlacement status", "clusterResourcePlacement", crpKObj)

// We skip checking the last resource condition (available) because it will be covered by checking isRolloutCompleted func.
for i := condition.RolloutStartedCondition; i < condition.TotalCondition-1; i++ {
Expand Down
Loading