feat: add init container to install fleet CRDs #1141
Conversation
Arvindthiru
force-pushed
the
CRDInitSideCar
branch
from
4409ec9 to
7509600
Compare
Arvindthiru
force-pushed
the
CRDInitSideCar
branch
from
d1f9080 to
565af68
Compare
Arvindthiru
force-pushed
the
CRDInitSideCar
branch
from
1ef75b2 to
1da8ccf
Compare
Arvindthiru
force-pushed
the
CRDInitSideCar
branch
from
344b47f to
0b2de1c
Compare
cmd/crdinstaller/utils/util.go
Outdated
| } | ||
|
|
||
| // Type assertion to make sure we have a CRD. | ||
| crd, ok := obj.(*apiextensionsv1.CustomResourceDefinition) |
There was a problem hiding this comment.
is the GVK returned not enough?
There was a problem hiding this comment.
We need to convert obj -> crd to access crd.Name to get object existing on the cluster. We can use check to achieve both (type assertion and get object name)
There was a problem hiding this comment.
what's that GVK? is that not always CustomResourceDefinition? or that's the real GVK of that CRD (i.e. crp.kube-fleet.io)?
There was a problem hiding this comment.
It's CustomResourceDefinition
Arvindthiru
force-pushed
the
CRDInitSideCar
branch
from
e574c46 to
4c736a0
Compare
Arvindthiru
changed the title
Arvindthiru
force-pushed
the
CRDInitSideCar
branch
from
a36cc2b to
9246062
Compare
cmd/crdinstaller/utils/util.go
Outdated
| } | ||
|
|
||
| // Type assertion to make sure we have a CRD. | ||
| crd, ok := obj.(*apiextensionsv1.CustomResourceDefinition) |
There was a problem hiding this comment.
what's that GVK? is that not always CustomResourceDefinition? or that's the real GVK of that CRD (i.e. crp.kube-fleet.io)?
ryanzhang-oss
left a comment
ryanzhang-oss
left a comment
There was a problem hiding this comment.
we need to add metrics and alert in the next PR
2 participants
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer