fix: fix TestPickBindingsToRoll rollout unit test #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arvindthiru
reviewed
Nov 22, 2024
Arvindthiru
reviewed
Nov 25, 2024
britaniar
force-pushed
the
fixRolloutUT
branch
from
3154222 to
c448fce
Compare
Arvindthiru
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Discrepancies found by Arvind when looking at unit tests.
I have:
Corrected variable naming based on readiness
Updated test cases accordingly
Run
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer