feat: Add CustomResourceDefinition trackability #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britaniar
force-pushed
the
resourceTrackers
branch
from
5c9ae37 to
e43b1c1
Compare
Contributor
ryanzhang-oss
left a comment
ryanzhang-oss
left a comment
There was a problem hiding this comment.
Why is there already test at test/e2e/rollout_test.go:1074 for CRD readiness?
Contributor
Author
|
The waitForCRDToBeReady in the rollout e2e was because we needed it to be ready in the hub before we can create the custom resource in the hub that it defines. It made the test flaky because it would sometimes take longer to become established. |
ryanzhang-oss
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have: add trackability for CustomResourceDefinitions
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer