Skip to content

Conversation

@ryanzhang-oss
Copy link
Contributor

@ryanzhang-oss ryanzhang-oss commented Dec 18, 2024

Description of your changes

support the ${MEMBER-CLASS-NAME} as an override value

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 11 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • pkg/controllers/workgenerator/override.go: Evaluated as low risk
  • pkg/controllers/workgenerator/override_test.go: Evaluated as low risk
  • test/e2e/actuals_test.go: Evaluated as low risk
  • test/e2e/placement_ro_test.go: Evaluated as low risk
  • pkg/controllers/workgenerator/controller.go: Evaluated as low risk
  • pkg/utils/overrider/overrider.go: Evaluated as low risk

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 13 changed files in this pull request and generated 1 comment.

Files not reviewed (8)
  • apis/placement/v1alpha1/common.go: Evaluated as low risk
  • apis/placement/v1alpha1/override_types.go: Evaluated as low risk
  • apis/placement/v1alpha1/zz_generated.deepcopy.go: Evaluated as low risk
  • pkg/controllers/workgenerator/controller.go: Evaluated as low risk
  • pkg/controllers/workgenerator/override.go: Evaluated as low risk
  • pkg/utils/overrider/overrider.go: Evaluated as low risk
  • test/e2e/placement_apply_strategy_test.go: Evaluated as low risk
  • pkg/utils/overrider/overrider_test.go: Evaluated as low risk
Comments suppressed due to low confidence (2)

test/e2e/actuals_test.go:125

  • The comment should be 'config map' instead of 'config map'.
// config map

test/e2e/actuals_test.go:119

  • Ensure that the function configMapPlacedOnClusterActual is covered by tests to verify its behavior.
func configMapPlacedOnClusterActual(cluster *framework.Cluster, wantConfigMap *corev1.ConfigMap) func() error {

@ryanzhang-oss ryanzhang-oss merged commit cb0c5f7 into Azure:main Dec 20, 2024
12 checks passed
@ryanzhang-oss ryanzhang-oss deleted the override-templating branch April 22, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants