Skip to content

Conversation

@im-samz
Copy link
Collaborator

@im-samz im-samz commented Dec 9, 2024

Looking to merge this milestone of work before the holidays.

Work done:

  • Added sections for each auth type, with workflow snippets
  • Organized the headings
  • Made the opening paragraph more readable
  • General content clean up

TODO:

  • Under ##End-to-end workflows, incorporate a full workflow with comments as a visual demonstration
  • Create another README for various scenarios that make use of the different Action parameters
  • Uploading a new version of each workflow
  • Add upload/download artifact as dependencies

Considering:

  • Changing H1 title to "Deploy Project to Azure Functions"
  • Instead of having all auth methods in the main README, describe just one and place instructions for the other two in a separate README.
  • Reducing the table of test results
  • Rewriting the ### Input parameters section in code block format to align with common practices

Tagging @ggailey777 for content review; @mattchenderson for auth review + overall feedback; @patelchandni, @ahmelsayed, @eamonoreilly for context

@im-samz
Copy link
Collaborator Author

im-samz commented Jan 24, 2025

Just merged Glenn's PR. Going to commit another round of edits. Before merging this one.

@im-samz
Copy link
Collaborator Author

im-samz commented Jan 31, 2025

@patelchandni / @eamonoreilly, could you take a look at the proposed README? I just need a reviewer to approve before I can merge this PR.

Copy link
Contributor

@mattchenderson mattchenderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review - will continue tomorrow.

Copy link
Contributor

@mattchenderson mattchenderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completing the partial review I started yesterday.

@im-samz im-samz merged commit b3b2682 into master Feb 27, 2025
14 checks passed
@im-samz im-samz deleted the samuelzhang/auth-refresh branch March 5, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants