Expose the Symbol type #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkuratczyk
requested review from
RickWinter,
jhendrixMSFT and
richardpark-msft
as code owners
Author
|
@microsoft-github-policy-service agree company="Broadcom" |
jhendrixMSFT
approved these changes
Nov 22, 2024
Member
jhendrixMSFT
left a comment
jhendrixMSFT
left a comment
There was a problem hiding this comment.
Can you please merge/rebase on main to fix the merge conflict?
Author
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make the encoding.Symbol type exposed as a public type
Symbol.We recently implemented AMQP Filter Expressions in RabbitMQ. If the client wants to filter based on a property, the property name should be encoded as a
Symbol, therefore the client needs to be able to use amap[amqp.Symbol]anyinamqp.NewLinkFilterSee https://github.com/rabbitmq/omq/blob/filter-properties/pkg/amqp10_client/consumer.go#L273-L279 for an example that works using a branch of go-amqp.
Thanks,