Feature/cronjob image substitution #433
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces fragile string-based image substitution with object-level YAML mutation and extends support to CronJob resources and initContainers.
- Parses Kubernetes manifests into objects, updates image fields, and re-serializes to YAML
- Introduces
updateImagesInK8sObjectandupdateImageInContainerArrayhelpers - Adds CronJob
spec.jobTemplateand initContainers handling
Comments suppressed due to low confidence (1)
src/utilities/manifestUpdateUtils.ts:122
- CronJob and initContainers image updates have been added; ensure new test cases cover both
spec.jobTemplatecontainers andinitContainersto prevent regressions.
obj?.kind?.toLowerCase() === KubernetesWorkload.CRON_JOB &&
Tatsinnit
reviewed
Jul 9, 2025
Tatsinnit
reviewed
Jul 9, 2025
Tatsinnit
approved these changes
Jul 9, 2025
bosesuneha
reviewed
Jul 15, 2025
bosesuneha
reviewed
Jul 17, 2025
| obj.spec.jobTemplate.spec.template.spec.initContainers[0].image | ||
| ).toBe('init:new') | ||
| }) | ||
| }) |
Member
There was a problem hiding this comment.
this looks good, can we add a test for updateContainerImagesInManifestFiles to validate that the yaml parsing works as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Add image substitution support for CronJobs (Addresses #243 )
This PR enhances the image substitution logic to support CronJobs by updating container image references in structured YAML objects. It replaces fragile string-based substitution with robust object-level mutation, ensuring compatibility across all standard workload types including CronJob, Deployment, and initContainers. CLOSED BECAUSE CODE WAS USED BY #436